From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cmd_bootm.c: Correct BOOTM_ERR_OVERLAP handling
Date: Tue, 2 Jul 2013 09:01:37 -0400 [thread overview]
Message-ID: <51D2CF31.3070101@ti.com> (raw)
In-Reply-To: <51D2CE5E.3050802@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/02/2013 08:58 AM, Andreas Bie?mann wrote:
> On 07/02/2013 02:35 PM, Tom Rini wrote:
>> On 07/02/2013 06:49 AM, Andreas Bie?mann wrote:
>>> Hi all,
>>
>>> On 06/28/2013 11:41 PM, Simon Glass wrote:
>>>> Hi Tom,
>>>>
>>>> On Fri, Jun 28, 2013 at 1:25 PM, Tom Rini <trini@ti.com>
>>>> wrote:
>>
>>> <snip>
>>
>>>>> @@ -660,34 +680,25 @@ static int do_bootm_states(cmd_tbl_t
>>>>> *cmdtp, int flag, int argc, } #endif /* Now run the OS! We
>>>>> hope this doesn't return */ - if (!ret && (states &
>>>>> BOOTM_STATE_OS_GO)) + if (!ret && (states &
>>>>> BOOTM_STATE_OS_GO)) { ret = boot_selected_os(argc, argv,
>>>>> BOOTM_STATE_OS_GO, images, boot_fn, &iflag); +
>>>>> if (ret) + goto err; + } + +
>>>>> return ret;
>>>>>
>>>>
>>>> Thanks for getting to the bottom of this.
>>>>
>>>> Just a question here - should this fall through to display
>>>> the error with the code below? For example if the subcommand
>>>> is not supported...
>>
>>> as pointed out by Simon the error message 'subcommand not
>>> supported' disappears with this patch.
>
> <snip>
>
>>> Who will fix that? I'll have a look for the avr32 specific
>>> part.
>>
>> The patch I posted yesterday should fix that.
>
> Oups, overseen, you mean http://patchwork.ozlabs.org/patch/256125/
> right?
Correct.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJR0s8xAAoJENk4IS6UOR1WuZAQAI2vkozEJyPKY6+6q7k3OOPP
P51Iut61IFYNREl9lYXXY/w6W08IC+K5SMD+4OvQZDhHJdYZBuOhXJjS9QlABQlg
9CE5nUvC3brhBJ90LIgno+6z02U1BmX/ackRe6fEGyOopBpibmsQGL7P2RhjX+Mo
g1oz/KisXJBsb+ZLQJptfuu5ZzQgjP2HT9z5yKmXXqJWWDayEOMHGcw2mlUIUgdE
xz/wm7mA45srwJfi/dRwavo4unswMOYFz8VzktCpQbVwIxgAkO7WmOYcxCkxFQ2t
3JZQVkrM6NL/b99ByZqrQy9FkmJotiWc/u4bQ3x1kn9KKxa+MSm4+NNS/UTc7dWh
z/wZ5DMNB9wYAzro0tVxLd7y6gZhOkhUCHsWUxV0ma0r8wd2sx3dLC85DwPpo2WA
JxWKAsJdY+NAs9phiVZ7h1iBMA/ekauRUtFJC9ahcCJf54AR89ppDWOY2Avxb+Y9
i6eX4jNUMJCjvJqzQL8M8gmJgnR1yXEAXylieIWgAzDU5ymIvxl6SvrzPCqxiTIX
YqZvjJkCxtDIDc1A5i4MkAnrogKIhoEH+2J6MzMpi+OZ1n+GyBaGuP2zcC9N5cD8
hJIXfsO8SepQJy+cAkE+9nOH5WvzdElMkUIPkZuhHYNzoMO83P5W6SE+mr/Qd+b6
948eA/6mlg1CopxPo8HU
=DxRB
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2013-07-02 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 18:21 [U-Boot] [PATCH] cmd_bootm.c: Correct BOOTM_ERR_OVERLAP handling Tom Rini
2013-06-28 20:25 ` [U-Boot] [PATCH v2] " Tom Rini
2013-06-28 21:41 ` Simon Glass
2013-06-28 22:07 ` Tom Rini
2013-06-28 23:59 ` Simon Glass
2013-07-02 10:49 ` Andreas Bießmann
2013-07-02 12:35 ` Tom Rini
2013-07-02 12:58 ` Andreas Bießmann
2013-07-02 13:01 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2CF31.3070101@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.