All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] avr32: fix do_bootm_linux
Date: Tue, 02 Jul 2013 16:06:52 +0200	[thread overview]
Message-ID: <51D2DE7C.3020905@gmail.com> (raw)
In-Reply-To: <20130702130334.GD16630@bill-the-cat>

On 07/02/2013 03:03 PM, Tom Rini wrote:
> On Tue, Jul 02, 2013 at 01:57:44PM +0200, Andreas Bie?mann wrote:
> 
>> Commit 35fc84fa1ff51e15ecd3e464dac87eb105ffed30 broke bootm on avr32. It
>> requires to call do_bootm_linux() with flag set to BOOTM_STATE_OS_PREP before
>> calling it again with flag set to BOOTM_STATE_OS_GO.
>> Fix this by allowing flag set to BOOTM_STATE_OS_PREP, this however will
>> require a complete refactoring later on.
>>
>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>>
>> ---
>>  arch/avr32/lib/bootm.c |    9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/avr32/lib/bootm.c b/arch/avr32/lib/bootm.c
>> index 87f3f9c..eedab9d 100644
>> --- a/arch/avr32/lib/bootm.c
>> +++ b/arch/avr32/lib/bootm.c
>> @@ -187,6 +187,15 @@ int do_bootm_linux(int flag, int argc, char * const argv[], bootm_headers_t *ima
>>  	struct	tag *params, *params_start;
>>  	char	*commandline = getenv("bootargs");
>>  
>> +	/*
>> +	 * allow the PREP bootm subcommand, it is required for bootm to work
>> +	 *
>> +	 * TODO: Andreas Bie??mann <andreas.devel@googlemail.com> refactor the
>> +	 * do_bootm_linux() for avr32
>> +	 */
>> +	if (flag & BOOTM_STATE_OS_PREP)
>> +		return 0;
>> +
>>  	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
>>  		return 1;
> 
> Good catch!  I'm going to make a v2 of this patch that fixes all of the
> other arches that're missing this hunk.

Ok, thank you Tom

Regards,

Andreas Bie?mann

      reply	other threads:[~2013-07-02 14:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 11:57 [U-Boot] [PATCH] avr32: fix do_bootm_linux Andreas Bießmann
2013-07-02 13:03 ` Tom Rini
2013-07-02 14:06   ` Andreas Bießmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D2DE7C.3020905@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.