From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Derr <simon.derr@bull.net>
Cc: netdev@vger.kernel.org, ericvh@gmail.com
Subject: Re: [PATCH 03/10] 9pnet: refactor struct p9_fcall alloc code
Date: Tue, 02 Jul 2013 20:40:58 +0400 [thread overview]
Message-ID: <51D3029A.8050100@cogentembedded.com> (raw)
In-Reply-To: <1372770684-25573-4-git-send-email-simon.derr@bull.net>
Hello.
On 02-07-2013 17:11, Simon Derr wrote:
> Signed-off-by: Simon Derr <simon.derr@bull.net>
> ---
> net/9p/client.c | 35 ++++++++++++++++++-----------------
> 1 files changed, 18 insertions(+), 17 deletions(-)
> diff --git a/net/9p/client.c b/net/9p/client.c
> index 47cd7d0..44691b9 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -204,6 +204,17 @@ free_and_return:
> return ret;
> }
>
> +struct p9_fcall *p9_fcall_alloc(int alloc_msize)
> +{
> + struct p9_fcall *fc;
Empty line wouldn't hurt here, after declaration.
> + fc = kmalloc(sizeof(struct p9_fcall) + alloc_msize, GFP_NOFS);
> + if (!fc)
> + return NULL;
> + fc->capacity = alloc_msize;
> + fc->sdata = (char *) fc + sizeof(struct p9_fcall);
> + return fc;
> +}
> +
[...]
WBR, Sergei
next prev parent reply other threads:[~2013-07-02 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 13:11 [PATCH 00/10] Improve 9P/RDMA Simon Derr
2013-07-02 13:11 ` [PATCH 01/10] 9P: Fix fcall allocation for rdma Simon Derr
2013-07-02 13:11 ` [PATCH 02/10] 9P/RDMA: rdma_request() needs not allocate req->rc Simon Derr
2013-07-02 13:11 ` [PATCH 03/10] 9pnet: refactor struct p9_fcall alloc code Simon Derr
2013-07-02 16:40 ` Sergei Shtylyov [this message]
2013-07-02 13:11 ` [PATCH 04/10] 9P/RDMA: increase P9_RDMA_MAXSIZE to 1MB Simon Derr
2013-07-02 13:11 ` [PATCH 05/10] 9P/RDMA: Protect against duplicate replies Simon Derr
2013-07-02 13:11 ` [PATCH 06/10] 9P/RDMA: Use a semaphore to protect the RQ Simon Derr
2013-07-02 13:11 ` [PATCH 07/10] 9P/RDMA: Do not free req->rc in error handling in rdma_request() Simon Derr
2013-07-02 13:11 ` [PATCH 08/10] 9P/RDMA: Improve error handling in rdma_request Simon Derr
2013-07-02 13:11 ` [PATCH 09/10] 9P/RDMA: count posted buffers without a pending request Simon Derr
2013-07-02 13:11 ` [PATCH 10/10] 9P: Add cancelled() to the transport functions Simon Derr
2013-07-02 16:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D3029A.8050100@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ericvh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.derr@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.