From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uu6LC-0004e2-5j for qemu-devel@nongnu.org; Tue, 02 Jul 2013 15:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uu6L9-0000Lx-R7 for qemu-devel@nongnu.org; Tue, 02 Jul 2013 15:34:18 -0400 Message-ID: <51D32B31.5030208@suse.de> Date: Tue, 02 Jul 2013 21:34:09 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1372279929-28836-1-git-send-email-rth@twiddle.net> <1372279929-28836-4-git-send-email-rth@twiddle.net> In-Reply-To: <1372279929-28836-4-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/9] tcg-ppc: Don't implement rem List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org, Alexander Graf , blauwirbel@gmail.com, qemu-ppc , aurelien@aurel32.net Am 26.06.2013 22:52, schrieb Richard Henderson: > Signed-off-by: Richard Henderson Reviewed-by: Andreas F=E4rber Andreas > --- > tcg/ppc/tcg-target.c | 14 -------------- > tcg/ppc/tcg-target.h | 2 +- > 2 files changed, 1 insertion(+), 15 deletions(-) >=20 > diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c > index 29ca934..453ab6b 100644 > --- a/tcg/ppc/tcg-target.c > +++ b/tcg/ppc/tcg-target.c > @@ -1671,18 +1671,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode = opc, const TCGArg *args, > tcg_out32 (s, DIVWU | TAB (args[0], args[1], args[2])); > break; > =20 > - case INDEX_op_rem_i32: > - tcg_out32 (s, DIVW | TAB (0, args[1], args[2])); > - tcg_out32 (s, MULLW | TAB (0, 0, args[2])); > - tcg_out32 (s, SUBF | TAB (args[0], 0, args[1])); > - break; > - > - case INDEX_op_remu_i32: > - tcg_out32 (s, DIVWU | TAB (0, args[1], args[2])); > - tcg_out32 (s, MULLW | TAB (0, 0, args[2])); > - tcg_out32 (s, SUBF | TAB (args[0], 0, args[1])); > - break; > - > case INDEX_op_mulu2_i32: > if (args[0] =3D=3D args[2] || args[0] =3D=3D args[3]) { > tcg_out32 (s, MULLW | TAB (0, args[2], args[3])); > @@ -1992,8 +1980,6 @@ static const TCGTargetOpDef ppc_op_defs[] =3D { > { INDEX_op_mul_i32, { "r", "r", "ri" } }, > { INDEX_op_div_i32, { "r", "r", "r" } }, > { INDEX_op_divu_i32, { "r", "r", "r" } }, > - { INDEX_op_rem_i32, { "r", "r", "r" } }, > - { INDEX_op_remu_i32, { "r", "r", "r" } }, > { INDEX_op_mulu2_i32, { "r", "r", "r", "r" } }, > { INDEX_op_sub_i32, { "r", "r", "ri" } }, > { INDEX_op_and_i32, { "r", "r", "ri" } }, > diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h > index 01b880e..b42d97c 100644 > --- a/tcg/ppc/tcg-target.h > +++ b/tcg/ppc/tcg-target.h > @@ -78,7 +78,7 @@ typedef enum { > =20 > /* optional instructions */ > #define TCG_TARGET_HAS_div_i32 1 > -#define TCG_TARGET_HAS_rem_i32 1 > +#define TCG_TARGET_HAS_rem_i32 0 > #define TCG_TARGET_HAS_rot_i32 1 > #define TCG_TARGET_HAS_ext8s_i32 1 > #define TCG_TARGET_HAS_ext16s_i32 1 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg