All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: armbru@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync
Date: Tue, 02 Jul 2013 13:57:32 -0600	[thread overview]
Message-ID: <51D330AC.5080008@redhat.com> (raw)
In-Reply-To: <1372689112-8093-4-git-send-email-kwolf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

On 07/01/2013 08:31 AM, Kevin Wolf wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi-schema.json | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)

Since this patch is not in yet, but DriveBackup IS in via commit
3037f364, should you expand the scope of this patch to cover that
command at the same time?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  parent reply	other threads:[~2013-07-02 19:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 14:31 [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions Kevin Wolf
2013-07-01 14:31 ` [Qemu-devel] [PATCH v3 1/3] qapi.py: Avoid code duplication Kevin Wolf
2013-07-01 16:21   ` Michael Roth
2013-07-01 14:31 ` [Qemu-devel] [PATCH v3 2/3] qapi.py: Allow top-level type reference for command definitions Kevin Wolf
2013-07-01 16:27   ` Michael Roth
2013-07-01 14:31 ` [Qemu-devel] [PATCH v3 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync Kevin Wolf
2013-07-01 16:31   ` Michael Roth
2013-07-02 19:57   ` Eric Blake [this message]
2013-07-08 17:37 ` [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions Luiz Capitulino
2013-07-09  8:06   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D330AC.5080008@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.