From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Mike Frysinger <vapier@gentoo.org>,
Anthony Green <green@moxielogic.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/5] TCG code generation performance fix
Date: Tue, 02 Jul 2013 12:59:21 -0700 [thread overview]
Message-ID: <51D33119.5050209@twiddle.net> (raw)
In-Reply-To: <1372793496-7756-1-git-send-email-afaerber@suse.de>
On 07/02/2013 12:31 PM, Andreas Färber wrote:
> Hello,
>
> As Richard explained, the purpose of having separate gen_intermediate_code()
> and gen_intermediate_code_pc() functions per target is to compile-optimize
> gen_intermediate_code_internal() for the non-_pc case.
>
> Multiple targets were using static rather than static inline though, fix this.
>
> I've split these off from my refactorings so that we can backport them to stable,
> and I'm rebasing my argument refactoring patches on top.
>
> No actual performance changes have been benchmarked, these changes serve more
> to align our targets as clear examples for new targets such as rl78 and bfin.
All:
Reviewed-by: Richard Henderson <rth@twiddle.net>
Although we should probably do some benchmarking at some point to see if
the duplicated code paths really do improve things over, say, unlikely().
But failing that we should at least have conformity of implementation.
r~
next prev parent reply other threads:[~2013-07-02 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 19:31 [Qemu-devel] [PATCH qom-cpu 0/5] TCG code generation performance fix Andreas Färber
2013-07-02 19:31 ` [Qemu-devel] [PATCH qom-cpu 1/5] target-cris: gen_intermediate_code_internal() should be inlined Andreas Färber
2013-07-02 19:31 ` [Qemu-devel] [PATCH qom-cpu 2/5] target-lm32: gen_intermediate_code_internal() should be inline Andreas Färber
2013-07-02 21:16 ` Michael Walle
2013-07-02 19:31 ` [Qemu-devel] [PATCH qom-cpu 3/5] target-microblaze: " Andreas Färber
2013-07-02 19:31 ` [Qemu-devel] [PATCH qom-cpu 4/5] target-moxie: " Andreas Färber
2013-07-02 19:31 ` [Qemu-devel] [PATCH qom-cpu 5/5] target-xtensa: " Andreas Färber
2013-07-02 19:59 ` Richard Henderson [this message]
2013-07-02 20:13 ` [Qemu-devel] [PATCH qom-cpu 0/5] TCG code generation performance fix Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D33119.5050209@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=green@moxielogic.com \
--cc=jcmvbkbc@gmail.com \
--cc=michael@walle.cc \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.