From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41484)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Uu7Ic-0006vJ-5K
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 16:35:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Uu7Ib-00019t-6B
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 16:35:42 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=56087
	helo=v220110690675601.yourvserver.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Uu7Ia-00019h-Vr
	for qemu-devel@nongnu.org; Tue, 02 Jul 2013 16:35:41 -0400
Message-ID: <51D33999.6000806@weilnetz.de>
Date: Tue, 02 Jul 2013 22:35:37 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 16.06.2013 12:02, schrieb Stefan Weil:
> This leak was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  fsdev/qemu-fsdev.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
> index 6eaf36d..ccfec13 100644
> --- a/fsdev/qemu-fsdev.c
> +++ b/fsdev/qemu-fsdev.c
> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>  
>      if (fsle->fse.ops->parse_opts) {
>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
> +            g_free(fsle->fse.fsdev_id);
> +            g_free(fsle);
>              return -1;
>          }
>      }

Ping?