Re: [RFC PATCH 3/6] Thermal: fix step_wise handling of THERMAL_TREND_DROPPING

[Eduardo Valentin <eduardo.valentin@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

On 17-06-2013 09:24, Zhang Rui wrote:
> Fixes two problems in the THERMAL_TREND_DROPPING
> handling code in step_wise governor.
> 1. When the temperature is higher than the trip point,
> we should not deactivate the thermal instance.

When temperature is higher than trip point, should it then get the
actions of the next trip point?

Does it mean that with this patch, all thermal instances assigned to
trip points below the cur temperature would be activated, right?

> 2. When the temperature is lower than the trip point,
> we should not activate the thermal instance.
> 

When would they get activated then?


> Also rephrase the code a bit to make it more readable.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/thermal/step_wise.c |   18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
> index d89e781..f0cc5e5 100644
> --- a/drivers/thermal/step_wise.c
> +++ b/drivers/thermal/step_wise.c
> @@ -75,13 +75,19 @@ static unsigned long get_target_state(struct thermal_instance *instance,
>  			next_target = instance->upper;
>  		break;
>  	case THERMAL_TREND_DROPPING:
> -		if (cur_state == instance->lower) {
> -			if (!throttle)
> -				next_target = THERMAL_NO_TARGET;
> +		if (throttle) {
> +			if (cur_state <= instance->lower)
> +				next_target = instance->lower;
> +			else
> +				next_target = cur_state > instance->upper ?
> +					instance->upper : cur_state - 1;
>  		} else {
> -			next_target = cur_state - 1;
> -			if (next_target > instance->upper)
> -				next_target = instance->upper;
> +			if (cur_state <= instance->lower ||
> +			    instance->target == THERMAL_NO_TARGET)
> +				next_target = THERMAL_NO_TARGET;
> +			else
> +				next_target = cur_state > instance->upper ?
> +					instance->upper : cur_state - 1;
>  		}
>  		break;
>  	case THERMAL_TREND_DROP_FULL:
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]