Re: [PATCH] cpuidle: Add Kconfig.arm and move calxeda and kirkwood

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 07/03/2013 07:26 AM, kpark3469@gmail.com wrote:
> From: Sahara <keun-o.park@windriver.com>
> 
> This patch adds Kconfig.arm for cpuidle drivers for ARM. And, this
> also moves calxeda and kirkwood to Kconfig.arm. Like cpufreq menu,
> "CPU Idle" menu is added to drivers/cpuidle/Kconfig.
> 
> Signed-off-by: Sahara <keun-o.park@windriver.com>
> ---

That sounds reasonable.

Please respin your patch on top of linux-pm-next and send it to me, I
will queue it in my tree. Rafael is not accepting any new material until
-rc1.

Thanks
  -- Daniel

>  drivers/cpuidle/Kconfig     |   11 ++++++-----
>  drivers/cpuidle/Kconfig.arm |   15 +++++++++++++++
>  drivers/cpuidle/Makefile    |    6 ++++--
>  3 files changed, 25 insertions(+), 7 deletions(-)
>  create mode 100644 drivers/cpuidle/Kconfig.arm
> 
> diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
> index c4cc27e..1f16116 100644
> --- a/drivers/cpuidle/Kconfig
> +++ b/drivers/cpuidle/Kconfig
> @@ -1,3 +1,4 @@
> +menu "CPU Idle"
>  
>  config CPU_IDLE
>  	bool "CPU idle PM support"
> @@ -33,10 +34,10 @@ config ARCH_NEEDS_CPU_IDLE_COUPLED
>  
>  if CPU_IDLE
>  
> -config CPU_IDLE_CALXEDA
> -	bool "CPU Idle Driver for Calxeda processors"
> -	depends on ARCH_HIGHBANK
> -	help
> -	  Select this to enable cpuidle on Calxeda processors.
> +menu "ARM CPU Idle Drivers"
> +depends on ARM
> +source "drivers/cpuidle/Kconfig.arm"
> +endmenu
>  
>  endif
> +endmenu
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> new file mode 100644
> index 0000000..d335dd8
> --- /dev/null
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -0,0 +1,15 @@
> +#
> +# ARM CPU Idle drivers
> +#
> +
> +config ARM_HIGHBANK_CPUIDLE
> +	bool "CPU Idle Driver for Calxeda processors"
> +	depends on ARCH_HIGHBANK
> +	help
> +	  Select this to enable cpuidle on Calxeda processors.
> +
> +config ARM_KIRKWOOD_CPUIDLE
> +	bool "CPU Idle Driver for Marvell Kirkwood SoCs"
> +	depends on ARCH_KIRKWOOD
> +	help
> +	  This adds the CPU Idle driver for Marvell Kirkwood SoCs.
> diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile
> index 0d8bd55..1d7ba91 100644
> --- a/drivers/cpuidle/Makefile
> +++ b/drivers/cpuidle/Makefile
> @@ -5,5 +5,7 @@
>  obj-y += cpuidle.o driver.o governor.o sysfs.o governors/
>  obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o
>  
> -obj-$(CONFIG_CPU_IDLE_CALXEDA) += cpuidle-calxeda.o
> -obj-$(CONFIG_ARCH_KIRKWOOD) += cpuidle-kirkwood.o
> +##################################################################################
> +# ARM SoC drivers
> +obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE) += cpuidle-calxeda.o
> +obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE) += cpuidle-kirkwood.o
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog