Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

[Paolo Bonzini <pbonzini@redhat.com>]

Just a couple more suggestions.

> /mjt
> 
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -825,7 +825,11 @@ a text mode. Generally only the VGA device models support text mode.
>  @item none
>  Do not display video output. The guest will still see an emulated
>  graphics card, but its output will not be displayed to the QEMU
> -user. This option differs from the -nographic option in that it
> +user.  The fact that we have no display is passed to firmware and
> +affects a few other places depending on the target architecture,
> +like switching console output to serial console or disabling keyboard
> +input.

Add an empty line here.

> +This option differs from the -nographic option in that it
>  only affects what is done with video output; -nographic also changes
>  the destination of the serial and parallel port data.
>  @item vnc
> @@ -841,10 +845,15 @@ STEXI
>  @findex -nographic
>  Normally, QEMU uses SDL to display the VGA output. With this option,
>  you can totally disable graphical output so that QEMU is a simple
> -command line application. The emulated serial port is redirected on
> -the console and muxed with the monitor (unless redirected elsewhere
> -explicitly). Therefore, you can still use QEMU to debug a Linux kernel
> -with a serial console.
> +command line application.  When this option is specified, unless
> +redirected explicitly, the emulated serial port and the monitor
> +are multiplexed on the console (stdio).

When this option is specified, the emulated serial port and the monitor
are by default multiplexed on the console (stdio).

> +This option is equivalent for

equivalent to

> +@example
> +-display none -serial mon:stdio -parallel none
> +@end example
> +Since even with no display, emulated serial port is still available,
> +you can use QEMU to debug a Linux kernel with a serial console.

I would just remove these two lines.

Paolo