All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Matyukevich <Sergey_Matyukevich@mentor.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: yocto@yoctoproject.org
Subject: [meta-ivi] [PATCHv2] connman: do not delete init scripts in bbappend
Date: Wed, 3 Jul 2013 15:59:11 +0400	[thread overview]
Message-ID: <51D4120F.6040306@mentor.com> (raw)
In-Reply-To: <CAJTo0LYDTjrq+aSQK638pedtiCpX+_a7uzYwd1Gbe0F41T7p6A@mail.gmail.com>

>> Connman init scripts are installed only if 'sysvinit' feature is enabled
>> in DISTRO_FEATURES: see commit 7c8160ccbe17d6e10bd7a09b91843182a89b9055 in
>> poky.
>>
>> Signed-off-by: Sergey Matyukevich<sergey_matyukevich@mentor.com>
>
> I'm curious as to why you're deleting the connman init scripts in meta-ivi...
>
> Ross

Hmm... Thanks for comment. It is good idea to take a break and to see 
the forest for the trees. Here is the second patch revision.

Connman init scripts are now installed only when 'sysvinit' feature is
enabled in DISTRO_FEATURES: commit 
7c8160ccbe17d6e10bd7a09b91843182a89b9055 in
poky. No need to remove them in bbappend: they are not installed for 
'systemd'-enabled
systems and they are needed for 'sysvinit'-enabled systems.

Signed-off-by: Sergey Matyukevich <sergey_matyukevich@mentor.com>
---
  recipes-connectivity/connman/connman_1.15.bbappend |    5 -----
  1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/recipes-connectivity/connman/connman_1.15.bbappend 
b/recipes-connectivity/connman/connman_1.15.bbappend
index cda612b..83e4b51 100644
--- a/recipes-connectivity/connman/connman_1.15.bbappend
+++ b/recipes-connectivity/connman/connman_1.15.bbappend
@@ -2,8 +2,3 @@ PRINC := "${@int(PRINC) + 2}"

  INITSCRIPT_NAME = ""
  INITSCRIPT_PARAMS = ""
-
-do_install_append() {
-	# Remove init scripts
-	rm -r ${D}${sysconfdir}/init.d
-}
-- 
1.7.2.5


  reply	other threads:[~2013-07-03 11:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03 11:28 [meta-ivi] [PATCH] connman: delete init scripts if 'sysvinit' feature is enabled Sergey Matyukevich
2013-07-03 11:36 ` Burton, Ross
2013-07-03 11:59   ` Sergey Matyukevich [this message]
2013-07-03 12:09     ` [meta-ivi] [PATCHv2] connman: do not delete init scripts in bbappend Burton, Ross
2013-07-03 12:31       ` Martin Jansa
2013-07-03 12:38       ` Behrens, Holger
2013-07-03 16:13         ` Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D4120F.6040306@mentor.com \
    --to=sergey_matyukevich@mentor.com \
    --cc=ross.burton@intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.