From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Gleb Natapov <gleb@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] KVM: s390: use cookies for ioeventfd
Date: Wed, 03 Jul 2013 17:30:40 +0200 [thread overview]
Message-ID: <51D443A0.9040703@redhat.com> (raw)
In-Reply-To: <1372861854-23043-3-git-send-email-cornelia.huck@de.ibm.com>
Il 03/07/2013 16:30, Cornelia Huck ha scritto:
> + /*
> + * Return cookie in gpr 2, but don't overwrite the register if the
> + * diagnose will be handled by userspace.
> + */
> + if (ret != -EOPNOTSUPP)
> + vcpu->run->s.regs.gprs[2] = ret;
I think this should now be "if (ret >= 0)".
> /* kvm_io_bus_write returns -EOPNOTSUPP if it found no match. */
The comment is now obsolete.
> return ret < 0 ? ret : 0;
Otherwise looks good, thanks!
Paolo
next prev parent reply other threads:[~2013-07-03 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 14:30 [PATCH v4 0/2] KVM: ioeventfd cookies Cornelia Huck
2013-07-03 14:30 ` [PATCH v4 1/2] KVM: kvm-io: support cookies Cornelia Huck
2013-07-03 15:05 ` Gleb Natapov
2013-07-03 14:30 ` [PATCH v4 2/2] KVM: s390: use cookies for ioeventfd Cornelia Huck
2013-07-03 15:30 ` Paolo Bonzini [this message]
2013-07-03 16:33 ` Cornelia Huck
2013-07-04 6:54 ` Paolo Bonzini
2013-07-14 9:25 ` Gleb Natapov
2013-07-14 10:19 ` Gleb Natapov
2013-07-15 7:56 ` Cornelia Huck
2013-07-15 12:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D443A0.9040703@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.