From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D08BFE01479 for ; Wed, 3 Jul 2013 09:13:44 -0700 (PDT) Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UuPgY-00017R-9F from Sergey_Matyukevich@mentor.com ; Wed, 03 Jul 2013 09:13:38 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 3 Jul 2013 09:13:38 -0700 Received: from [137.202.140.158] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Wed, 3 Jul 2013 17:13:36 +0100 Message-ID: <51D44DAF.2010305@mentor.com> Date: Wed, 3 Jul 2013 20:13:35 +0400 From: Sergey Matyukevich Organization: Mentor Graphics User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20121216 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: "Behrens, Holger" References: <1372850887-10185-1-git-send-email-sergey_matyukevich@mentor.com> <51D4120F.6040306@mentor.com> <7A688B48FC95D148BFE83E098348BE50393435C4@ALA-MBA.corp.ad.wrs.com> In-Reply-To: <7A688B48FC95D148BFE83E098348BE50393435C4@ALA-MBA.corp.ad.wrs.com> X-OriginalArrivalTime: 03 Jul 2013 16:13:38.0572 (UTC) FILETIME=[46F2ECC0:01CE7808] Cc: "yocto@yoctoproject.org" Subject: Re: [meta-ivi] [PATCHv2] connman: do not delete init scripts in bbappend X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2013 16:13:49 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/03/2013 04:38 PM, Behrens, Holger wrote: > Hi, > >> On 3 July 2013 12:59, Sergey Matyukevich >> wrote: >>> Hmm... Thanks for comment. It is good idea to take a break and to see the >>> forest for the trees. Here is the second patch revision. >>> >>> Connman init scripts are now installed only when 'sysvinit' feature is >>> enabled in DISTRO_FEATURES: commit >> 7c8160ccbe17d6e10bd7a09b91843182a89b9055 >>> in >>> poky. No need to remove them in bbappend: they are not installed for >>> 'systemd'-enabled >>> systems and they are needed for 'sysvinit'-enabled systems. >>> >>> Signed-off-by: Sergey Matyukevich >>> --- >>> recipes-connectivity/connman/connman_1.15.bbappend | 5 ----- >>> 1 files changed, 0 insertions(+), 5 deletions(-) >>> >>> diff --git a/recipes-connectivity/connman/connman_1.15.bbappend >>> b/recipes-connectivity/connman/connman_1.15.bbappend >>> index cda612b..83e4b51 100644 >>> --- a/recipes-connectivity/connman/connman_1.15.bbappend >>> +++ b/recipes-connectivity/connman/connman_1.15.bbappend >>> @@ -2,8 +2,3 @@ PRINC := "${@int(PRINC) + 2}" >>> >>> INITSCRIPT_NAME = "" >>> INITSCRIPT_PARAMS = "" >>> - >>> -do_install_append() { >>> - # Remove init scripts >>> - rm -r ${D}${sysconfdir}/init.d >>> -} >>> -- >>> 1.7.2.5 >> >> In that case, you can delete INITSCRIPT_NAME and INITSCRIPT_PARAMS too >> surely. Then all you're left is the PRINC, so you can delete that if >> you don't care/are using the PR service, or delete that bbappend when >> connman 1.16 is integrated. > > I agree that we could now start with the clean-up of the meta-ivi layer, given the fact that systemd is now supported by oe-core. Which makes this .bbappend obsolete. And so agree with Ross to "delete that bbappend when connman 1.16 is integrated". I created a card [1] and added it to the "Next Up" stack in Trello, so that we don't forget. > > Regards, > Holger > > [1] https://trello.com/c/bmWpT6lU Does it make sense to fix the current connman bbappend which is going to be in use for a while ? In its current state it affects distros which enable 'systemd' feature and disable 'sysvinit'. One of the following two options can be chosen. The first one was finalized in this thread: diff --git a/recipes-connectivity/connman/connman_1.15.bbappend b/recipes-connectivity/connman/connman_1.15.bbappend index cda612b..f1deaf2 100644 --- a/recipes-connectivity/connman/connman_1.15.bbappend +++ b/recipes-connectivity/connman/connman_1.15.bbappend @@ -1,9 +1 @@ PRINC := "${@int(PRINC) + 2}" - -INITSCRIPT_NAME = "" -INITSCRIPT_PARAMS = "" - -do_install_append() { - # Remove init scripts - rm -r ${D}${sysconfdir}/init.d -} There is also another [minimalistic and failsafe] option: diff --git a/recipes-connectivity/connman/connman_1.15.bbappend b/recipes-connectivity/connman/connman_1.15.bbappend index cda612b..2e5f355 100644 --- a/recipes-connectivity/connman/connman_1.15.bbappend +++ b/recipes-connectivity/connman/connman_1.15.bbappend @@ -5,5 +5,5 @@ INITSCRIPT_PARAMS = "" do_install_append() { # Remove init scripts - rm -r ${D}${sysconfdir}/init.d + rm -rf ${D}${sysconfdir}/init.d } Thanks, Sergey