From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6AC10E0141B for ; Wed, 3 Jul 2013 11:53:57 -0700 (PDT) Received: by mail-pd0-f172.google.com with SMTP id z10so360096pdj.17 for ; Wed, 03 Jul 2013 11:53:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=mMvHnV5e9/n8jsdVV7zu8xfz45a0K3qR5GfdDXAnGYw=; b=NmV0MWy7YnvI/03Dtf1Mt7+lSth3PokrLK+jxQe1NtaMN8t57zw1ywzdgIsviACbh3 q58xTxfeWp43Wi5YL1ygMB6qD+ARlDGUKAUq8HkEOFt009Tq5ErJVXMfSeQZugjHhtRr 2AhNSr735fMwNJArfqebu6/KOqFczPETSWddJFDDrKbsLbRB9QSGK9ZX4WaM1uxYYB0X uu5Z26N7D23ZxCTfuPJvjeM5LKxUleFYodkmlm/flUGXpbcnhUrkffQmWBHWCu79oYXe MqIA6e3tfcuEgtVwsRa3LB4gheGfszUp0ED6OQB/1krHVHfs4jzPgBcUW0rUfW0BR+A2 fLew== X-Received: by 10.66.102.6 with SMTP id fk6mr3669825pab.184.1372877637581; Wed, 03 Jul 2013 11:53:57 -0700 (PDT) Received: from [192.168.0.55] ([70.96.116.236]) by mx.google.com with ESMTPSA id dj5sm32519810pbc.25.2013.07.03.11.53.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Jul 2013 11:53:56 -0700 (PDT) Message-ID: <51D47341.40206@boundarydevices.com> Date: Wed, 03 Jul 2013 11:53:53 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Erik_Bot=F6?= References: <1372860715-22416-1-git-send-email-erik.boto@pelagicore.com> In-Reply-To: <1372860715-22416-1-git-send-email-erik.boto@pelagicore.com> X-Gm-Message-State: ALoCoQlrzqPsHUAXTb7HYF05AVPp3glsODIpj4vPVND8AHJS6bmNlnSMNkZC4BmYmjKF9iCiLV4z Cc: meta-freescale@yoctoproject.org Subject: Re: [linux-boundary][PATCHv2] egalax_ts: Always report all touch points before input_sync() X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2013 18:54:00 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Hi Erik, Sorry for the delay, but I finally got around to checking this patch. On 07/03/2013 07:11 AM, Erik Botö wrote: > The previous behavior of the driver did not work properly with Qt5 > QtQuick multi touch-point gestures, due to how touch-points are > reported when removing a touch-point. My interpretation of the > available documentation [1] was that the driver should report all > touch-points between SYN_REPORTs, but it is not explicitly stated so. > I've found another mail-thread [2] where the creator of the protocol > states: > > "The protocol defines a generic way of sending a variable amount of > contacts. The contact count is obtained by counting the number of > non-empty finger packets between SYN_REPORT events."-Henrik Rydberg > > I think this verifies my assumption that all touch-points should be > reported between SYN_REPORTs, otherwise it can not be used to obtain > the count. > Your assumptions are correct, and if I read things correctly, they're already fixed, but in a different source tree... I'm guessing that someone forgot to mention that there are **two** primary kernel trees for i.MX. Android and not-Android. The Android kernel seems to have this fixed in a different way, by doing some additional book-keeping of current touches: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/input/touchscreen/egalax_ts.c?id=3b9608406bb699de5ff02760c745e62212b4c280 In Freescale's repository, the current Android stuff is in a tag (jb4.2.2_1.0.0-ga) instead of a branch, so it's a bit difficult to navigate through the web interface: http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tag/?id=jb4.2.2_1.0.0-ga Hey Freescalers, can we get a head nod that we can consolidate these? I think all that's needed is to add the SINGLE_TOUCH stuff into the Android branch. Erik, can you try out the Android version and see if it works for you? Please advise, Eric