All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4 V3] EXYNOS: Move files from board/samsung to arch/arm
Date: Thu, 04 Jul 2013 11:01:37 +0900	[thread overview]
Message-ID: <51D4D781.8010709@samsung.com> (raw)
In-Reply-To: <CAPs=JDfwyEgmh0Ww9X4vjm3+QfPrsiMC0+v-eLNyW1kfRP_D7Q@mail.gmail.com>

>>> diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch/arm/include/asm/arch-exynos/cpu.h
>>> index 36b98c8..75dbe26 100644
>>> --- a/arch/arm/include/asm/arch-exynos/cpu.h
>>> +++ b/arch/arm/include/asm/arch-exynos/cpu.h
>>> @@ -115,7 +115,7 @@
>>>  #define EXYNOS5_DMC_PHY0_BASE                0x10C00000
>>>  #define EXYNOS5_DMC_PHY1_BASE                0x10C10000
>>
>> maybe it can be dmc0 and dmc1
>> If you want to keep the interface with exynos4.
> EXYNOS4 donot have seperate Phy controller it is a part of  DMC controller.
> then I need to add following for EXYNOS4
> EXYNOS4_DMC_PHY1_BASE    DEVICE_NOT_AVAILABLE
> EXYNOS4_DMC_PHY_BASE       DEVICE_NOT_AVAILABLE
> 
>>
>>>  #define EXYNOS5_GPIO_PART3_BASE              0x10D10000
>>> -#define EXYNOS5_DMC_CTRL_BASE                0x10DD0000
>>> +#define EXYNOS5_DMC0_BASE            0x10DD0000
>>
>> why?
> if we want to make funstion to get the DMC base address it is needed
> to be added for EXYNOS5 as well
> hence made this change.
>>
>>>  #define EXYNOS5_GPIO_PART1_BASE              0x11400000
>>>  #define EXYNOS5_MIPI_DSIM_BASE               0x11D00000
>>>  #define EXYNOS5_USB_HOST_EHCI_BASE   0x12110000
>>> @@ -135,6 +135,7 @@
>>>
>>>  #define EXYNOS5_ADC_BASE             DEVICE_NOT_AVAILABLE
>>>  #define EXYNOS5_MODEM_BASE           DEVICE_NOT_AVAILABLE
>>> +#define EXYNOS5_DMC1_BASE            DEVICE_NOT_AVAILABLE
>>
>> It looks weird.
> Since EXYNOS4 has 2 DMC controllers and EXYNOS5 has only 1 DMC
> controller I had to add this to avoid compilation error.
> Please do let me know if  you are fine with these changes.
>>

I suggest following.

EXYNOS4_DMC_BASE	0x-
EXYNOS4_DMC_PHY_BASE	DEVICE_NOT_AVAILABLE

EXYNOS4X12_DMC_BASE	0x-
EXYNOS4X12_DMC_PHY_BASE	DEVICE_NOT_AVAILABLE

EXYNOS5_DMC_PHY_BASE	0x-
EXYNOS5_DMC_BASE	0x-

then we need to add 2 SAMSUNG_BASE.

SAMSUNG_BASE(dmc, DMC_BASE)
SAMSUNG_BASE(dmc_phy, DMC_PHY_BASE)

and we can access dmc1 and dmc phy1 by offset.

What do you think about it?

Thanks,
Minkyu Kang.

  reply	other threads:[~2013-07-04  2:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 13:12 [U-Boot] [PATCH 0/4 V3]EXYNOS: Convert Assembly code to c and make it common Rajeshwari Shinde
2013-07-02 13:12 ` [U-Boot] [PATCH 1/4 V3] EXYNOS: Add API for power reset and exit wakeup Rajeshwari Shinde
2013-07-02 13:12 ` [U-Boot] [PATCH 2/4 V3] EXYNOS: LDS file move to common Rajeshwari Shinde
2013-07-02 13:12 ` [U-Boot] [PATCH 3/4 V3] EXYNOS4210: Configure GPIO for uart Rajeshwari Shinde
2013-07-02 13:12 ` [U-Boot] [PATCH 4/4 V3] EXYNOS: Move files from board/samsung to arch/arm Rajeshwari Shinde
2013-07-03 12:10   ` Minkyu Kang
2013-07-03 12:39     ` Rajeshwari Birje
2013-07-04  2:01       ` Minkyu Kang [this message]
2013-07-04  5:27         ` Rajeshwari Birje
2013-07-04  5:57           ` Minkyu Kang
2013-07-04  6:04             ` Rajeshwari Birje

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D4D781.8010709@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.