From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk Date: Thu, 4 Jul 2013 10:16:24 +0530 Message-ID: <51D4FE20.6000805@ti.com> References: <1372860209-3504-1-git-send-email-coelho@ti.com> <1372860209-3504-3-git-send-email-coelho@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372860209-3504-3-git-send-email-coelho@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Luciano Coelho Cc: mark.rutland@arm.com, nm@ti.com, mturquette@linaro.org, linux-doc@vger.kernel.org, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, rob.herring@calxeda.com, grant.likely@linaro.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 7/3/2013 7:33 PM, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of hiding this irq flag setting behind the quirk, have the > board files set the flags during initialization. This will be more > meaningful than driver-specific quirks when we switch to DT. > > Additionally, fix missing gpio_request() calls in the boarding files > (so that setting the flags actually works). > > Cc: Tony Lindgren > Cc: Sekhar Nori > Signed-off-by: Luciano Coelho > --- > arch/arm/mach-davinci/board-da850-evm.c | 8 +++++- For the board-da850-evm.c change, Acked-by: Sekhar Nori Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:32787 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467Ab3GDErD (ORCPT ); Thu, 4 Jul 2013 00:47:03 -0400 Message-ID: <51D4FE20.6000805@ti.com> (sfid-20130704_064719_534667_E0D4C866) Date: Thu, 4 Jul 2013 10:16:24 +0530 From: Sekhar Nori MIME-Version: 1.0 To: Luciano Coelho CC: , , , , , , , , , , , , Subject: Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk References: <1372860209-3504-1-git-send-email-coelho@ti.com> <1372860209-3504-3-git-send-email-coelho@ti.com> In-Reply-To: <1372860209-3504-3-git-send-email-coelho@ti.com> Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 7/3/2013 7:33 PM, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of hiding this irq flag setting behind the quirk, have the > board files set the flags during initialization. This will be more > meaningful than driver-specific quirks when we switch to DT. > > Additionally, fix missing gpio_request() calls in the boarding files > (so that setting the flags actually works). > > Cc: Tony Lindgren > Cc: Sekhar Nori > Signed-off-by: Luciano Coelho > --- > arch/arm/mach-davinci/board-da850-evm.c | 8 +++++- For the board-da850-evm.c change, Acked-by: Sekhar Nori Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Thu, 4 Jul 2013 10:16:24 +0530 Subject: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk In-Reply-To: <1372860209-3504-3-git-send-email-coelho@ti.com> References: <1372860209-3504-1-git-send-email-coelho@ti.com> <1372860209-3504-3-git-send-email-coelho@ti.com> Message-ID: <51D4FE20.6000805@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7/3/2013 7:33 PM, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of hiding this irq flag setting behind the quirk, have the > board files set the flags during initialization. This will be more > meaningful than driver-specific quirks when we switch to DT. > > Additionally, fix missing gpio_request() calls in the boarding files > (so that setting the flags actually works). > > Cc: Tony Lindgren > Cc: Sekhar Nori > Signed-off-by: Luciano Coelho > --- > arch/arm/mach-davinci/board-da850-evm.c | 8 +++++- For the board-da850-evm.c change, Acked-by: Sekhar Nori Thanks, Sekhar