All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 5/5] ARM: at91: atmel_nand: add code to check the ONFI parameter ECC requirement
Date: Thu, 4 Jul 2013 15:28:57 +0800	[thread overview]
Message-ID: <51D52439.2050509@atmel.com> (raw)
In-Reply-To: <1372889576.8183.153@snotra>

On 7/4/2013 6:12 AM, Scott Wood wrote:
> On 07/02/2013 10:11:49 PM, Josh Wu wrote:
>> +        if (!get_onfi_ecc_param(chip, cap, sector_size))
>> +            MTDDEBUG(MTD_DEBUG_LEVEL1, "ONFI params, minimum 
>> required ECC: %d bits in %d bytes\n",
>> +                *cap, *sector_size);
>
> Use braces around multi-line if/loop bodies, even if it's a single 
> statement.
>
> Otherwise, ACK this patchset.

thanks, I'll resend this patch with braces around.

>
> -Scott

Best Regards,
Josh Wu

  reply	other threads:[~2013-07-04  7:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03  3:11 [U-Boot] [PATCH v3 0/5] ARM: at91: atmel_nand: check ONFI ecc minimum requirement Josh Wu
2013-07-03  3:11 ` [U-Boot] [PATCH v3 1/5] ARM: at91: atmel_nand: pmecc driver will select the galois table by sector size Josh Wu
2013-08-22 15:00   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03  3:11 ` [U-Boot] [PATCH v3 2/5] ARM: at91: sama5d3: remove unused definition about PMECC alpha table offset Josh Wu
2013-08-22 15:00   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03  3:11 ` [U-Boot] [PATCH v3 3/5] linux/compat.h: move dev_err, dev_info and dev_dbg from usb driver to compat.h Josh Wu
2013-08-22 15:00   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03  3:11 ` [U-Boot] [PATCH v3 4/5] mtd: atmel_nand: alloc memory instead of use static array for pmecc data Josh Wu
2013-08-22 15:00   ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03  3:11 ` [U-Boot] [PATCH v3 5/5] ARM: at91: atmel_nand: add code to check the ONFI parameter ECC requirement Josh Wu
2013-07-03 22:12   ` Scott Wood
2013-07-04  7:28     ` Josh Wu [this message]
2013-07-04  7:36     ` [U-Boot] [resend][PATCH " Josh Wu
2013-08-22 15:01       ` [U-Boot] [U-Boot, resend, v3, " Andreas Bießmann
2013-08-09 10:00 ` [U-Boot] [PATCH v3 0/5] ARM: at91: atmel_nand: check ONFI ecc minimum requirement Josh Wu
2013-08-10  0:13   ` Scott Wood
2013-08-22 10:07 ` Josh Wu
2013-08-22 10:29   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D52439.2050509@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.