From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 5/5] Viridian: cleanup Date: Thu, 4 Jul 2013 10:38:47 +0100 Message-ID: <51D542A7.6040707@citrix.com> References: <51C8092A02000078000DFDA0@nat28.tlf.novell.com> <51C80C8302000078000DFDDB@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1803423762936226251==" Return-path: In-Reply-To: <51C80C8302000078000DFDDB@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , George Dunlap , Eddie Dong , xen-devel , paul.durrant@citrix.com, Jun Nakajima , Yang Z Zhang List-Id: xen-devel@lists.xenproject.org --===============1803423762936226251== Content-Type: multipart/alternative; boundary="------------070502020902080005090904" --------------070502020902080005090904 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 24/06/13 08:08, Jan Beulich wrote: > - functions used only locally should be static > - constify parameters of dump functions > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/hvm/viridian.c > +++ b/xen/arch/x86/hvm/viridian.c > @@ -111,7 +111,7 @@ int cpuid_viridian_leaves(unsigned int l > return 1; > } > > -void dump_guest_os_id(struct domain *d) > +static void dump_guest_os_id(const struct domain *d) > { > gdprintk(XENLOG_INFO, "GUEST_OS_ID:\n"); > gdprintk(XENLOG_INFO, "\tvendor: %x\n", > @@ -128,7 +128,7 @@ void dump_guest_os_id(struct domain *d) > d->arch.hvm_domain.viridian.guest_os_id.fields.build_number); > } > > -void dump_hypercall(struct domain *d) > +static void dump_hypercall(const struct domain *d) > { > gdprintk(XENLOG_INFO, "HYPERCALL:\n"); > gdprintk(XENLOG_INFO, "\tenabled: %x\n", > @@ -137,7 +137,7 @@ void dump_hypercall(struct domain *d) > (unsigned long)d->arch.hvm_domain.viridian.hypercall_gpa.fields.pfn); > } > > -void dump_apic_assist(struct vcpu *v) > +static void dump_apic_assist(const struct vcpu *v) > { > gdprintk(XENLOG_INFO, "APIC_ASSIST[%d]:\n", v->vcpu_id); > gdprintk(XENLOG_INFO, "\tenabled: %x\n", > @@ -180,7 +180,7 @@ static void enable_hypercall_page(struct > put_page_and_type(page); > } > > -void initialize_apic_assist(struct vcpu *v) > +static void initialize_apic_assist(struct vcpu *v) > { > struct domain *d = v->domain; > unsigned long gmfn = v->arch.hvm_vcpu.viridian.apic_assist.fields.pfn; > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------070502020902080005090904 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 24/06/13 08:08, Jan Beulich wrote:
- functions used only locally should be static
- constify parameters of dump functions

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/arch/x86/hvm/viridian.c
+++ b/xen/arch/x86/hvm/viridian.c
@@ -111,7 +111,7 @@ int cpuid_viridian_leaves(unsigned int l
     return 1;
 }
 
-void dump_guest_os_id(struct domain *d)
+static void dump_guest_os_id(const struct domain *d)
 {
     gdprintk(XENLOG_INFO, "GUEST_OS_ID:\n");
     gdprintk(XENLOG_INFO, "\tvendor: %x\n",
@@ -128,7 +128,7 @@ void dump_guest_os_id(struct domain *d)
             d->arch.hvm_domain.viridian.guest_os_id.fields.build_number);
 }
 
-void dump_hypercall(struct domain *d)
+static void dump_hypercall(const struct domain *d)
 {
     gdprintk(XENLOG_INFO, "HYPERCALL:\n");
     gdprintk(XENLOG_INFO, "\tenabled: %x\n",
@@ -137,7 +137,7 @@ void dump_hypercall(struct domain *d)
             (unsigned long)d->arch.hvm_domain.viridian.hypercall_gpa.fields.pfn);
 }
 
-void dump_apic_assist(struct vcpu *v)
+static void dump_apic_assist(const struct vcpu *v)
 {
     gdprintk(XENLOG_INFO, "APIC_ASSIST[%d]:\n", v->vcpu_id);
     gdprintk(XENLOG_INFO, "\tenabled: %x\n",
@@ -180,7 +180,7 @@ static void enable_hypercall_page(struct
     put_page_and_type(page);
 }
 
-void initialize_apic_assist(struct vcpu *v)
+static void initialize_apic_assist(struct vcpu *v)
 {
     struct domain *d = v->domain;
     unsigned long gmfn = v->arch.hvm_vcpu.viridian.apic_assist.fields.pfn;






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------070502020902080005090904-- --===============1803423762936226251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1803423762936226251==--