From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] libxl: ignore run_hotplug_scripts setting
 when backend_domid!=0
Date: Thu, 4 Jul 2013 13:39:51 +0200
Message-ID: <51D55F07.3010102@citrix.com>
References: <20130409184101.07E2D52@duch.mimuw.edu.pl>
	<CAFLBxZYzgDgOQT6fTWScMwDQ9uLt6wScY-whBu3ja_uARtLbpg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZYzgDgOQT6fTWScMwDQ9uLt6wScY-whBu3ja_uARtLbpg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Marek Marczykowski <marmarek@invisiblethingslab.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 04/07/13 12:42, George Dunlap wrote:
> On Tue, Apr 9, 2013 at 9:49 AM, Marek Marczykowski
> <marmarek@invisiblethingslab.com> wrote:
>> Instead of forcing the user to change run_hotplug_scripts setting
>> globally, just ignore it for backends outside of dom0.
>>
>> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> 
> This seems like a good idea -- Roger / Ian, any thoughts?

We already have this behaviour in libxl (see libxl_device.c:device_hotplug):

/*
 * If device is attached from a driver domain don't try to execute
 * hotplug scripts
 */
if (aodev->dev->backend_domid != LIBXL_TOOLSTACK_DOMID)
    goto out;

This was introduced by commit 05bfd984dfe7014f1f5ea1133608b9bab589c120