From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] libxl: ignore run_hotplug_scripts setting when backend_domid!=0 Date: Thu, 4 Jul 2013 13:40:18 +0100 Message-ID: <51D56D32.20107@eu.citrix.com> References: <20130409184101.07E2D52@duch.mimuw.edu.pl> <51D55F07.3010102@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <51D55F07.3010102@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Cc: Ian Campbell , Marek Marczykowski , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/07/13 12:39, Roger Pau Monn=E9 wrote: > On 04/07/13 12:42, George Dunlap wrote: >> On Tue, Apr 9, 2013 at 9:49 AM, Marek Marczykowski >> wrote: >>> Instead of forcing the user to change run_hotplug_scripts setting >>> globally, just ignore it for backends outside of dom0. >>> >>> Signed-off-by: Marek Marczykowski >> This seems like a good idea -- Roger / Ian, any thoughts? > We already have this behaviour in libxl (see libxl_device.c:device_hotplu= g): > > /* > * If device is attached from a driver domain don't try to execute > * hotplug scripts > */ > if (aodev->dev->backend_domid !=3D LIBXL_TOOLSTACK_DOMID) > goto out; > > This was introduced by commit 05bfd984dfe7014f1f5ea1133608b9bab589c120 But you still get an error on domain creation if you actually set a = non-dom0 backend and run_hotplug_scripts is set; so you can't actually = run in "mixed mode" anyway. This patch should, I think, enable you to = have libxl run the scripts in dom0, but udev run them in domu. -George