All of lore.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <waiman.long@hp.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jeff Layton <jlayton@redhat.com>,
	Miklos Szeredi <mszeredi@suse.cz>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ian Kent <raven@themaw.net>,
	autofs mailing list <autofs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Andi Kleen <andi@firstfloor.org>,
	"Chandramouleeswaran, Aswin" <aswin@hp.com>,
	"Norton, Scott J" <scott.norton@hp.com>
Subject: Re: [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount
Date: Thu, 04 Jul 2013 10:51:29 -0400	[thread overview]
Message-ID: <51D58BF1.1050202@hp.com> (raw)
In-Reply-To: <20130704045956.GO4165@ZenIV.linux.org.uk>

On 07/04/2013 12:59 AM, Al Viro wrote:
> On Wed, Jul 03, 2013 at 08:50:07PM -0700, Linus Torvalds wrote:
>> On Wed, Jul 3, 2013 at 8:33 PM, Waiman Long<Waiman.Long@hp.com>  wrote:
>>> Because of the d_count name change made in dcache.h, all references
>>> to d_count have to be changed to d_refcount.  There is no change in
>>> logic and everything should just work.
>> These filesystem patches need to be just joined into the same patch
>> that does the d_count ->  d_refcount change.
>>
>> Otherwise the kernel won't build in lots of configurations for some
>> commits, which makes things like bisecting much more painful than it
>> should be.
>>
>> So we can't do piece-meal changes that break the build for parts of the tree.
> Frankly, my preference here would be to add static inline unsigned d_count(...)
> and convert the uses of ->d_count outside of fs/{dcache.c,namei.c} and
> include/linux/dcache.c to it as the first commit.  All users outside those
> are readers, so there's no point playing with macros in this case...

Yes, I could do that.

Regards,
Longman



  reply	other threads:[~2013-07-04 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  3:33 [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount Waiman Long
2013-07-04  3:50 ` Linus Torvalds
2013-07-04  4:59   ` Al Viro
2013-07-04 14:51     ` Waiman Long [this message]
2013-07-04 14:47   ` Waiman Long
2013-07-04 17:53     ` Linus Torvalds
2013-07-04 21:50       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D58BF1.1050202@hp.com \
    --to=waiman.long@hp.com \
    --cc=andi@firstfloor.org \
    --cc=aswin@hp.com \
    --cc=autofs@vger.kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mszeredi@suse.cz \
    --cc=peterz@infradead.org \
    --cc=raven@themaw.net \
    --cc=rostedt@goodmis.org \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.