From: Gmail <marco.stornelli@gmail.com>
To: linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Marco Stornelli <marco.stornelli@gmail.com>,
"H. Peter Anvin" <hpa@linux.intel.com>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] fsfreeze: return EINTR from mnt_want_write and mnt_want_write_file
Date: Thu, 04 Jul 2013 18:19:00 +0200 [thread overview]
Message-ID: <51D5A074.9040906@gmail.com> (raw)
Replaced sb_start_write with sb_start_write_killable inside
mnt_want_write and mnt_want_write_file.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/namei.c | 6 ++++++
fs/namespace.c | 8 ++++++--
ipc/mqueue.c | 6 +++++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 9ed9361..d8e3eab 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2750,6 +2750,8 @@ static int do_last(struct nameidata *nd, struct path *path,
retry_lookup:
if (op->open_flag & (O_CREAT | O_TRUNC | O_WRONLY | O_RDWR)) {
error = mnt_want_write(nd->path.mnt);
+ if (error == -EINTR)
+ goto out;
if (!error)
got_write = true;
/*
@@ -3053,6 +3055,10 @@ struct dentry *kern_path_create(int dfd, const char *pathname,
/* don't fail immediately if it's r/o, at least try to report other errors */
err2 = mnt_want_write(nd.path.mnt);
+ if (err2 == -EINTR) {
+ dentry = ERR_PTR(-EINTR);
+ goto out;
+ }
/*
* Do the final lookup.
*/
diff --git a/fs/namespace.c b/fs/namespace.c
index 7b1ca9b..7a7bc97 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -345,7 +345,9 @@ int mnt_want_write(struct vfsmount *m)
{
int ret;
- sb_start_write(m->mnt_sb);
+ ret = sb_start_write_killable(m->mnt_sb);
+ if (ret < 0)
+ return ret;
ret = __mnt_want_write(m);
if (ret)
sb_end_write(m->mnt_sb);
@@ -405,7 +407,9 @@ int mnt_want_write_file(struct file *file)
{
int ret;
- sb_start_write(file->f_path.mnt->mnt_sb);
+ ret = sb_start_write_killable(file->f_path.mnt->mnt_sb);
+ if (ret < 0)
+ return ret;
ret = __mnt_want_write_file(file);
if (ret)
sb_end_write(file->f_path.mnt->mnt_sb);
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index e4e47f6..e8fdc03 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -800,7 +800,11 @@ SYSCALL_DEFINE4(mq_open, const char __user *, u_name, int, oflag, umode_t, mode,
if (fd < 0)
goto out_putname;
- ro = mnt_want_write(mnt); /* we'll drop it in any case */
+ ro = mnt_want_write(mnt);
+ if (ro == -EINTR) {
+ fd = ro;
+ goto out_putname;
+ }
error = 0;
mutex_lock(&root->d_inode->i_mutex);
path.dentry = lookup_one_len(name->name, root, strlen(name->name));
--
1.7.3.4
next reply other threads:[~2013-07-04 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 16:19 Gmail [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-04 6:50 [PATCH 4/4] fsfreeze: return EINTR from mnt_want_write and mnt_want_write_file Marco Stornelli
2013-04-26 8:53 Marco Stornelli
2013-04-29 12:35 ` Jan Kara
2013-04-30 6:18 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D5A074.9040906@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=hpa@linux.intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.