From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, claudio.fontana@huawei.com,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros
Date: Thu, 04 Jul 2013 10:28:09 -0700 [thread overview]
Message-ID: <51D5B0A9.9040206@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-Pfjxp4FD-soOcgtERzP7r3s6mMcWLs--Oey5YNT13WA@mail.gmail.com>
On 07/04/2013 03:53 AM, Peter Maydell wrote:
> On 3 July 2013 22:29, Richard Henderson <rth@twiddle.net> wrote:
>> This allows TCG_TARGET_HAS_* to be a variable rather than a constant,
>> which allows easier support for differing ISA levels for the host.
>
> The effect of this is that TCG_OPF_NOT_PRESENT means "if set,
> op is definitely not present; if not set, op might or might
> not be present", right? Which is OK because it's just a debug
> guard/sanity check. (That might be worth noting in a comment
> I guess.)
Well, if not set, an entry must be present in the operands table.
E.g. for arm division, the { INDEX_op_div_i32, "r", "r", "r" } entry
is always there, even if TCG_TARGET_HAS_div_i32 evaluates to false
at runtime. The entry must be there Just In Case the expression might
be true.
r~
next prev parent reply other threads:[~2013-07-04 17:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 21:29 [Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 01/14] tcg: Add myself to general TCG maintainership Richard Henderson
2013-07-04 10:38 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 02/14] tcg: Split rem requirement from div requirement Richard Henderson
2013-07-04 10:44 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 03/14] tcg-arm: Don't implement rem Richard Henderson
2013-07-04 10:45 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 04/14] tcg-ppc: " Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 05/14] tcg-ppc64: " Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros Richard Henderson
2013-07-04 10:53 ` Peter Maydell
2013-07-04 17:28 ` Richard Henderson [this message]
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 07/14] tcg: Simplify logic using TCG_OPF_NOT_PRESENT Richard Henderson
2013-07-04 10:54 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 08/14] tcg-arm: Make use of conditional availability of opcodes for divide Richard Henderson
2013-07-04 11:02 ` Peter Maydell
2013-07-04 17:33 ` Richard Henderson
2013-07-04 17:39 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 09/14] tcg-arm: Simplify logic in detecting the ARM ISA in use Richard Henderson
2013-07-04 11:22 ` Peter Maydell
2013-07-04 17:44 ` Richard Henderson
2013-07-04 19:29 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 10/14] tcg-arm: Use AT_PLATFORM to detect the host ISA Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 11/14] tcg: Fix high_pc fields in .debug_info Richard Henderson
2013-07-04 11:25 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 12/14] tcg: Move the CIE and FDE header definitions to common code Richard Henderson
2013-07-04 11:29 ` Peter Maydell
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 13/14] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size Richard Henderson
2013-07-03 21:29 ` [Qemu-devel] [PATCH v3 14/14] tcg-arm: Implement tcg_register_jit Richard Henderson
2013-07-04 11:29 ` Peter Maydell
2013-07-04 9:28 ` [Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D5B0A9.9040206@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=claudio.fontana@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.