From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933251Ab3GDVPK (ORCPT ); Thu, 4 Jul 2013 17:15:10 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752932Ab3GDVPI (ORCPT ); Thu, 4 Jul 2013 17:15:08 -0400 Message-ID: <51D5E5D2.8020202@nod.at> Date: Thu, 04 Jul 2013 23:14:58 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ramkumar Ramachandra CC: LKML , Al Viro , Jeff Dike Subject: Re: [PATCH 1/3] arch/um/Makefile: remove dead code References: <1372971797-23518-1-git-send-email-artagnon@gmail.com> <1372971797-23518-2-git-send-email-artagnon@gmail.com> In-Reply-To: <1372971797-23518-2-git-send-email-artagnon@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.07.2013 23:03, schrieb Ramkumar Ramachandra: > arch/um/Makefile is included in the toplevel Makefile:495. Well before > that, it unconditionally sets $SUBARCH (in Makefile:168) as follows: > > SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \ > -e s/sun4u/sparc64/ \ > -e s/arm.*/arm/ -e s/sa110/arm/ \ > -e s/s390x/s390/ -e s/parisc64/parisc/ \ > -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \ > -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ ) > > It is clearly impossible for $SUBARCH to be set as i386 or x86_64. > Therefore, any code that checks $SUBARCH against these values is dead > code. No. If you build UML for x86_64 you override SUBARCH. i.e. make linux ARCH=um SUBARCH=x86_64 > Cc: Al Viro > Cc: Richard Weinberger > Cc: Jeff Dike > Signed-off-by: Ramkumar Ramachandra NAK. Thanks, //richard