From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes
Date: Thu, 04 Jul 2013 23:15:26 +0200 [thread overview]
Message-ID: <51D5E5EE.2090403@redhat.com> (raw)
In-Reply-To: <51D5D1DF.4060003@redhat.com>
On 07/04/13 21:49, Paolo Bonzini wrote:
> Il 04/07/2013 11:53, Wanlong Gao ha scritto:
>> As you know, QEMU can't direct it's memory allocation now, this may cause
>> guest cross node access performance regression.
>> And, the worse thing is that if PCI-passthrough is used,
>> direct-attached-device uses DMA transfer between device and qemu process.
>> All pages of the guest will be pinned by get_user_pages().
>>
>> KVM_ASSIGN_PCI_DEVICE ioctl
>> kvm_vm_ioctl_assign_device()
>> =>kvm_assign_device()
>> => kvm_iommu_map_memslots()
>> => kvm_iommu_map_pages()
>> => kvm_pin_pages()
>>
>> So, with direct-attached-device, all guest page's page count will be +1 and
>> any page migration will not work. AutoNUMA won't too.
>>
>> So, we should set the guest nodes memory allocation policy before
>> the pages are really mapped.
>>
>> According to this patch set, we are able to set guest nodes memory policy
>> like following:
>>
>> -numa node,nodeid=0,mem=1024,cpus=0,mem-policy=membind,mem-hostnode=0-1
>> -numa node,nodeid=1,mem=1024,cpus=1,mem-policy=interleave,mem-hostnode=1
>
> Did you see my suggestion to use instead something like this:
>
> -numa node,nodeid=0,cpus=0 -numa node,nodeid=1,cpus=1 \
> -numa mem,nodeid=0,size=1G,policy=membind,hostnode=0-1
> -numa mem,nodeid=1,size=2G,policy=interleave,hostnode=1
>
> With an eye to when we'll support memory hotplug, I think it is better.
> It is not hard to implement it using the OptsVisitor; see
> 14aa0c2de045a6c2fcfadf38c04434fd15909455 for an example of a complex
> schema described with OptsVistor.
See also the commit msg of its grandparent, eb7ee2cb, for general notes.
The containing series is d195325b^..1a0c0958.
A more recent (and simpler) use is the 8ccbad5c^..0c764a9d sub-series.
Thanks for the reference, Paolo.
Laszlo
next prev parent reply other threads:[~2013-07-04 21:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 9:53 [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option Wanlong Gao
2013-07-05 18:41 ` Eduardo Habkost
2013-07-08 19:02 ` Eric Blake
2013-07-08 19:25 ` Eduardo Habkost
2013-07-08 19:25 ` Anthony Liguori
2013-07-09 3:28 ` Wanlong Gao
2013-07-09 3:34 ` Eric Blake
2013-07-14 11:34 ` Paolo Bonzini
2013-07-15 21:33 ` Eric Blake
2013-07-16 6:24 ` Paolo Bonzini
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 02/10] NUMA: Add numa_info structure to contain numa nodes info Wanlong Gao
2013-07-05 19:32 ` Eduardo Habkost
2013-07-05 20:09 ` Andreas Färber
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 03/10] NUMA: Add Linux libnuma detection Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 04/10] NUMA: parse guest numa nodes memory policy Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 05/10] NUMA: handle Error in cpus, mpol and hostnode parser Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 06/10] NUMA: split out the common range parser Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 07/10] NUMA: set guest numa nodes memory policy Wanlong Gao
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node Wanlong Gao
2013-07-08 18:25 ` Luiz Capitulino
2013-07-08 18:34 ` Luiz Capitulino
2013-07-08 18:50 ` Andreas Färber
2013-07-08 19:03 ` Luiz Capitulino
2013-07-15 11:18 ` Wanlong Gao
2013-07-08 19:16 ` Eric Blake
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 09/10] NUMA: add hmp command set-mpol Wanlong Gao
2013-07-08 18:32 ` Luiz Capitulino
2013-07-04 9:53 ` [Qemu-devel] [PATCH V4 10/10] NUMA: show host memory policy info in info numa command Wanlong Gao
2013-07-05 18:49 ` Eduardo Habkost
2013-07-08 18:36 ` Luiz Capitulino
2013-07-04 19:49 ` [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes Paolo Bonzini
2013-07-04 21:15 ` Laszlo Ersek [this message]
2013-07-05 0:55 ` Wanlong Gao
2013-07-05 0:54 ` Wanlong Gao
2013-07-05 19:18 ` Eduardo Habkost
2013-07-11 10:32 ` Peter Huang(Peng)
2013-07-11 13:10 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D5E5EE.2090403@redhat.com \
--to=lersek@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=bsd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.