From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality Date: Fri, 05 Jul 2013 15:30:25 +0900 Message-ID: <51D66801.2080502@samsung.com> References: <51CD1E1B.2020403@samsung.com> <171613676.bYSyJq1iqA@avalon> <51D520BD.8010105@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id B4143E66FB for ; Thu, 4 Jul 2013 23:30:25 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MPG00K27A2D5V00@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 05 Jul 2013 15:30:23 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: Laurent Pinchart , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On 07/05/2013 02:38 PM, Dave Airlie wrote: > On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim wrote: >> On 07/04/2013 07:11 AM, Laurent Pinchart wrote: >>> Hi Joonyoung, >>> >>> Thank you for the patches. >>> >>> On Friday 28 June 2013 14:24:43 Joonyoung Shim wrote: >>>> Hello, >>>> >>>> This is the second version patchset. >>>> >>>> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for >>>> dma_buf. We can use prime helpers for dma_buf by commit >>>> 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so >>>> this patchset is to replace from using GEM CMA specific functions to >>>> using prime helpers. >>>> >>>> >>>> To Laurent, >>>> >>>> It is merged a patch to cache mapping from DRM Prime, can this patchset >>>> get your ack? >>> There you go (and sorry for the late reply) >>> >>> Acked-by: Laurent Pinchart >>> >>> By the way, between the initial version of the GEM CMA PRIME patch and the >>> version that got merged in v3.10, commit >>> 011c2282c74db120f01a8414edc66c3f217f5511 ("drm: prime: fix refcounting on >>> the >>> dmabuf import error path") was introduced. The GEM CMA PRIME code in v3.10 >>> thus has a refcounting bug :-( >>> >>> Should this patch set go to -stable, or should we cook up a special fix ? >> >> I'm not sure it's better to choose which way. >> >> Dave, how we should do about that problem? > I think a special fix for stable once we get these merged to Linus. > OK, i will post a patch for a special fix. Thanks.