From: Lars-Peter Clausen <lars@metafoo.de>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-iio@vger.kernel.org, alexandre.belloni@free-electrons.com,
jic23@kernel.org, marex@denx.de, fabio.estevam@freescale.com
Subject: Re: [PATCH 4/4] iio: mxs-lradc: add write_raw function to modify scale
Date: Fri, 05 Jul 2013 12:41:31 +0200 [thread overview]
Message-ID: <51D6A2DB.20407@metafoo.de> (raw)
In-Reply-To: <1373013039-19461-5-git-send-email-hector.palacios@digi.com>
On 07/05/2013 10:30 AM, Hector Palacios wrote:
> Added write_raw function to manipulate the optional divider_by_two
> through the scaling attribute out of the available scales.
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 55 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index 7f98c99..acd05d6 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -188,6 +188,7 @@ struct mxs_lradc {
>
> const int *vref_mv;
> unsigned int scale_avail[LRADC_MAX_TOTAL_CHANS][2][2];
> + bool is_divided[LRADC_MAX_TOTAL_CHANS];
unsigned int, you do math with it and initialize it to either 0 or 1.
Otherwise the patch looks good.
prev parent reply other threads:[~2013-07-05 10:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 8:30 [PATCH 0/4] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-05 8:30 ` [PATCH 1/4] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-05 11:37 ` Marek Vasut
2013-07-05 12:40 ` Hector Palacios
2013-07-05 13:10 ` Marek Vasut
2013-07-05 14:35 ` Hector Palacios
2013-07-05 17:17 ` Lars-Peter Clausen
2013-07-06 10:08 ` Jonathan Cameron
2013-07-06 10:13 ` Marek Vasut
2013-07-10 10:47 ` Hector Palacios
2013-07-10 11:49 ` Marek Vasut
2013-07-10 14:45 ` Hector Palacios
2013-07-10 15:22 ` Marek Vasut
2013-07-05 8:30 ` [PATCH 2/4] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-05 10:32 ` Lars-Peter Clausen
2013-07-05 15:49 ` Hector Palacios
2013-07-05 16:56 ` Marek Vasut
2013-07-05 11:41 ` Marek Vasut
2013-07-05 16:42 ` Hector Palacios
2013-07-05 16:59 ` Marek Vasut
2013-07-05 17:08 ` Lars-Peter Clausen
2013-07-05 17:39 ` Marek Vasut
2013-07-06 9:59 ` Jonathan Cameron
2013-07-05 8:30 ` [PATCH 3/4] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-05 10:40 ` Lars-Peter Clausen
2013-07-08 8:27 ` Hector Palacios
2013-07-08 8:42 ` Lars-Peter Clausen
2013-07-05 11:46 ` Marek Vasut
2013-07-08 8:51 ` Hector Palacios
2013-07-08 13:05 ` Marek Vasut
2013-07-05 8:30 ` [PATCH 4/4] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-05 10:41 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D6A2DB.20407@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.