From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH] libxl_json: Fix backport of JSON_BOOL to 4.2.2 Date: Fri, 5 Jul 2013 11:30:11 -0400 Message-ID: <51D6E683.9020906@terremark.com> References: <1373037105-1574-1-git-send-email-dslutz@verizon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373037105-1574-1-git-send-email-dslutz@verizon.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Don Slutz Cc: ian.campbell@citrix.com, alex@alex.org.uk, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, anthony.perard@citrix.com List-Id: xen-devel@lists.xenproject.org Looks like I had an issue with the mailer I used, and this did not get to anyone at citrix.com. Resending via a different SMTP server. -Don Slutz On 07/05/13 11:11, Don Slutz wrote: > Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of obj->u.b > Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not. > > This shows up by vnc-port and vnc-listen are missing in xenstore when they should not be. > > Signed-off-by: Don Slutz > --- > tools/libxl/libxl_json.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c > index 72b52e8..0810630 100644 > --- a/tools/libxl/libxl_json.c > +++ b/tools/libxl/libxl_json.c > @@ -474,6 +474,7 @@ static int json_callback_boolean(void *opaque, int boolean) > > if ((obj = libxl__json_object_alloc(ctx->gc, JSON_BOOL)) == NULL) > return 0; > + obj->u.b = boolean; > > if (libxl__json_object_append_to(ctx->gc, obj, ctx->current) == -1) { > libxl__json_object_free(ctx->gc, obj);