From: "Arend van Spriel" <arend@broadcom.com>
To: "Hector Palacios" <hector.palacios@digi.com>
Cc: "Kalle Valo" <kvalo@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath6kl-devel@qca.qualcomm.com" <ath6kl-devel@qca.qualcomm.com>
Subject: Re: Passing a custom MAC to ath6kl
Date: Fri, 5 Jul 2013 20:02:10 +0200 [thread overview]
Message-ID: <51D70A22.20607@broadcom.com> (raw)
In-Reply-To: <51D6EC90.40009@digi.com>
On 07/05/2013 05:56 PM, Hector Palacios wrote:
> Dear Kalle,
>
> On 07/05/2013 05:49 PM, Kalle Valo wrote:
>> Hector Palacios <hector.palacios@digi.com> writes:
>>
>>> Is there a way to pass a custom MAC address to the ath6kl upstream
>>> driver?
>>
>> Not right now. It has been a common feature request so I'm hoping
>> someone will implement it soon.
>>
>>> In the ISC version of the driver, a softmac.c file is provided that
>>> reads a MAC from a file if a module parameter softmac_enable=1 is
>>> passed. Is there any reason why this has not made it upstream?
>>
>> Providing mac address through a file is too ugly for upstream. We need
>> to implement it properly using the proper interface.
>
> I totally agree. What would be the proper interface for that?
Add .ndo_set_mac_address() callback in main.c and go from there.
int (*ndo_set_mac_address)(struct net_device *dev, void *addr);
Regards,
Arend
> Best regards,
> --
> Hector Palacios
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-05 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 15:21 Passing a custom MAC to ath6kl Hector Palacios
2013-07-05 15:49 ` Kalle Valo
2013-07-05 15:56 ` Hector Palacios
2013-07-05 18:02 ` Arend van Spriel [this message]
2013-07-05 20:23 ` Kalle Valo
2013-07-29 11:14 ` Priti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D70A22.20607@broadcom.com \
--to=arend@broadcom.com \
--cc=ath6kl-devel@qca.qualcomm.com \
--cc=hector.palacios@digi.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.