From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] libxl_json: Fix backport of JSON_BOOL to
 4.2.2
Date: Fri, 5 Jul 2013 16:40:47 -0400
Message-ID: <51D72F4F.6060904@terremark.com>
References: <1373037105-1574-1-git-send-email-dslutz@verizon.com>
	<51D6E683.9020906@terremark.com>
	<365670c2-8ac1-4782-9efd-040f5a3fa163@email.android.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <365670c2-8ac1-4782-9efd-040f5a3fa163@email.android.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: jbeulich@suse.com, Ian.Jackson@eu.citrix.com, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, alex@alex.org.uk, anthony.perard@citrix.com, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 07/05/13 16:29, Konrad Rzeszutek Wilk wrote:
> Don Slutz <dslutz@verizon.com> wrote:
>
>> Looks like I had an issue with the mailer I used, and this did not get
>> to anyone at citrix.com. Resending via a different SMTP server.
>>     -Don Slutz
>>
>> On 07/05/13 11:11, Don Slutz wrote:
>>> Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of
>> obj->u.b
>>> Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not.
>>>
>>> This shows up by vnc-port and vnc-listen are missing in xenstore when
>> they should not be.
>>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>>> ---
>>>    tools/libxl/libxl_json.c |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
>>> index 72b52e8..0810630 100644
>>> --- a/tools/libxl/libxl_json.c
>>> +++ b/tools/libxl/libxl_json.c
>>> @@ -474,6 +474,7 @@ static int json_callback_boolean(void *opaque,
>> int boolean)
>>>    
>>>        if ((obj = libxl__json_object_alloc(ctx->gc, JSON_BOOL)) ==
>> NULL)
>>>            return 0;
>>> +    obj->u.b = boolean;
>>>    
>>>        if (libxl__json_object_append_to(ctx->gc, obj, ctx->current) ==
>> -1) {
>>>            libxl__json_object_free(ctx->gc, obj);
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
> Could you also include in the commit description not just the git commit id but also also the title of said patches? Thanks
How does this look:

     Commit 2b3072ed0cbeed8c0385f20e92ba0f1201db8a17 has the setting of 
obj->u.b
     libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.

     Commit 6a2aca9fdef0499e613715baf107f2296b9007cf does not.
     libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.

     This shows up by vnc-port and vnc-listen are missing in xenstore 
when they should not be.

for the commit message?
    -Don Slutz