From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 94849E00343 for ; Fri, 5 Jul 2013 18:07:37 -0700 (PDT) Received: by mail-pd0-f175.google.com with SMTP id 4so2379680pdd.20 for ; Fri, 05 Jul 2013 18:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=POR+SsoIfNdXLmz9GRrfjrAf2uvtxILBOi9K1Cezmr0=; b=pIo0dbOV2ZdFQQY1DTpEBmt3aNBddpCIOH2inDpEYd6IqN+KpFJANUWUP74CI6BScl SymU0b8PjfI+v2QAdqawmwVbXhpT06KxIUJWSxwyLugcJuP0ZSLczYZ38BaVYOJoBmTL RptG0gmvAg+8pD+iqnaoaq7VbVqLmIcc+o0itSDcXv+esYwyHYtxTEx4MHTZwZ29eaS0 PcycBsWfaQeTPnNSlG8fKjsYrMAATGZkqLv1MqrVtpMKdtQy0bSFWbJPXOadSfygskXh /7Y7Z5ygS3PjWrVFaCnbrch9e1ahdeq1Qka9JBh/hRzHLP2NIxEgouPx9KRFCmQJZOOv RZgA== X-Received: by 10.66.146.66 with SMTP id ta2mr13567375pab.11.1373072857221; Fri, 05 Jul 2013 18:07:37 -0700 (PDT) Received: from [192.168.0.55] ([70.96.116.236]) by mx.google.com with ESMTPSA id ix3sm9532900pbc.37.2013.07.05.18.07.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Jul 2013 18:07:36 -0700 (PDT) Message-ID: <51D76DD4.4080404@boundarydevices.com> Date: Fri, 05 Jul 2013 18:07:32 -0700 From: Eric Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Erik_Bot=F6?= References: <1372860715-22416-1-git-send-email-erik.boto@pelagicore.com> <51D47341.40206@boundarydevices.com> In-Reply-To: X-Gm-Message-State: ALoCoQkMmWU3s1lDVGVRrlNH/t9eUHiOKKteVOZf+z6LaxmcNtyddAA9Dp2wxCKc+ZODBJ3phWJK Cc: "meta-freescale@yoctoproject.org" Subject: Re: [linux-boundary][PATCHv2] egalax_ts: Always report all touch points before input_sync() X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jul 2013 01:07:38 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Hi Erik, On 07/04/2013 11:18 PM, Erik Botö wrote: > Hi Eric, > > On Wed, Jul 3, 2013 at 8:53 PM, Eric Nelson > > wrote: > > Hi Erik, > > Sorry for the delay, but I finally got around to checking this patch. > > > On 07/03/2013 07:11 AM, Erik Botö wrote: > > The previous behavior of the driver did not work properly with Qt5 > QtQuick multi touch-point gestures, due to how touch-points are > reported when removing a touch-point. My interpretation of the > available documentation [1] was that the driver should report all > touch-points between SYN_REPORTs, but it is not explicitly > stated so. > I've found another mail-thread [2] where the creator of the protocol > states: > > "The protocol defines a generic way of sending a variable amount of > contacts. The contact count is obtained by counting the number of > non-empty finger packets between SYN_REPORT events."-Henrik Rydberg > > I think this verifies my assumption that all touch-points should be > reported between SYN_REPORTs, otherwise it can not be used to obtain > the count. > > > Your assumptions are correct, and if I read things correctly, they're > already fixed, but in a different source tree... > > I'm guessing that someone forgot to mention that there are **two** > primary kernel trees for i.MX. Android and not-Android. > > The Android kernel seems to have this fixed in a different way, > by doing some additional book-keeping of current touches: > http://git.freescale.com/git/__cgit.cgi/imx/linux-2.6-imx.__git/tree/drivers/input/__touchscreen/egalax_ts.c?id=__3b9608406bb699de5ff02760c745e6__2212b4c280 > > > In Freescale's repository, the current Android stuff is in a tag > (jb4.2.2_1.0.0-ga) instead of a branch, so it's a bit difficult > to navigate through the web interface: > > http://git.freescale.com/git/__cgit.cgi/imx/linux-2.6-imx.__git/tag/?id=jb4.2.2_1.0.0-ga > > > Hey Freescalers, can we get a head nod that we can consolidate > these? I think all that's needed is to add the SINGLE_TOUCH stuff > into the Android branch. > > Erik, can you try out the Android version and see if it works for > you? > > > I did a quick test where I just copied the Android version, removed the > EARLYSUSPEND stuff so it would build inside a regular kernel but it is > not behaving properly for me. Even one finger clicks doesn't seem to > work, looks like it never gets released. > Thanks for testing that. It doesn't surprise me that Android expects something off-spec. > Unfortunately I don't have much time to investigate this further. But > since the two kernels are different anyway I guess there's no danger > with merging my patch suggestion in the non-android kernel? > No worries on my end. I was just hoping to consolidate the two, since it makes future bug fixes easier. Regards, Eric