From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Date: Thu, 4 Jul 2013 16:16:43 +0300 Message-ID: Subject: Issue with porting i2c driver to k3.10 (iio) From: Oleksandr Kravchenko To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, gregkh@linuxfoundation.org, jic23@cam.ac.uk Content-Type: multipart/alternative; boundary=089e0111d842b0fb4704e0af6365 List-ID: --089e0111d842b0fb4704e0af6365 Content-Type: text/plain; charset=ISO-8859-1 Hi All, I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some questions regarding upstreaming of it. 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data()). Does anyone know why this issue may be occurred? 2. Can I send this driver without using Industrial I/O framework? Thanks in advance. -- Oleksandr Kravchenko GlobalLogic P +380633213187 P +380994930248 www.globallogic.com http://www.globallogic.com/email_disclaimer.txt --089e0111d842b0fb4704e0af6365 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi All,

I wrote i2c driver for APDS-9300 light sens= or in drivers/misc, but I have some questions regarding upstreaming of it.<= br>1. It works properly in kernel-3.4, but it works very slow in kernel-3.1= 0 (on mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_r= ead_data()). Does anyone know why this issue may be occurred?
2. Can I send this driver without using Industrial I/O framework?

Th= anks in advance.

--
Oleksandr Kravchenko
GlobalLogic
P +380633213187
<= span style=3D"vertical-align:baseline;font-variant:normal;font-style:normal= ;font-size:12px;background-color:transparent;text-decoration:none;font-fami= ly:Arial;font-weight:normal">P +380994930248
w= ww.globallogic.com

http://www.globa= llogic.com/email_disclaimer.txt
--089e0111d842b0fb4704e0af6365-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 4 Jul 2013 09:19:11 -0700 From: Greg KH To: Oleksandr Kravchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, jic23@cam.ac.uk Subject: Re: Issue with porting i2c driver to k3.10 (iio) Message-ID: <20130704161911.GC20907@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote: > Hi All, > > I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some > questions regarding upstreaming of it. > 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on > mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data > ()). Does anyone know why this issue may be occurred? What is "slow"? Have you run 'perf' on the driver to see where it is spending time? > 2. Can I send this driver without using Industrial I/O framework? No, why would you even want to? greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:38567 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943Ab3GFLrN (ORCPT ); Sat, 6 Jul 2013 07:47:13 -0400 Message-ID: <51D803BC.8000403@kernel.org> Date: Sat, 06 Jul 2013 12:47:08 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Greg KH CC: Oleksandr Kravchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, jic23@cam.ac.uk Subject: Re: Issue with porting i2c driver to k3.10 (iio) References: <20130704161911.GC20907@kroah.com> In-Reply-To: <20130704161911.GC20907@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/04/2013 05:19 PM, Greg KH wrote: > On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote: >> Hi All, >> >> I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some >> questions regarding upstreaming of it. >> 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on >> mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data >> ()). Does anyone know why this issue may be occurred? > > What is "slow"? Have you run 'perf' on the driver to see where it is > spending time? > >> 2. Can I send this driver without using Industrial I/O framework? > > No, why would you even want to? Looks like a fairly standard light sensor so drivers/iio/light. Actually very close in design to some of the TAOS parts such as those supported by the tsl2563 driver if you want a reference driver to compare with. Jonathan