Re: [Qemu-devel] [PATCH RFC qom-cpu 41/41] cpu: Introduce CPUClass::gdb_{read, write}_register()

["Andreas Färber" <afaerber@suse.de>]

Am 01.07.2013 20:07, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas Färber wrote:
>> Replace GET_REG*() macros by gdb_get_reg*() inline functions for
>> clarity and drop breaks after return.
>>
>> Allows to move target-specific code to new target-*/gdbstub.c files.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> This one's quite hard to read.

True. Apart from the IMO too generically named GET_REG*() macros, I
needed to fix an awful number of Coding Style issues, which we might
want to do upfront. I could also do the GET_REG*() -> gdb_get_reg*()
sweep in place and split off the break cleanups, too.

> I wonder if there's value in splitting out functions one target at a time into
> the new gdbstub.c files, and only afterward performing a few minor textual
> changes to transform those functions into the CPUClass methods?

That's not so easy, but I'll think of something. #include'ing the C
files until the final change to CPUClass hooks might work...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg