All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Kirkwood <mark.kirkwood@catalyst.net.nz>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Possible bug in src/Makefile.am
Date: Sun, 07 Jul 2013 17:15:23 +1200	[thread overview]
Message-ID: <51D8F96B.5040902@catalyst.net.nz> (raw)

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

I noticed when building with prefix=/usr/local that the install step 
produced an usr/local/sbin hierarchy *under* /usr/local (i.e 
/usr/local/usr/local/sbin) with ceph_disk and friends (i.e 
ceph_sbin_SCRIPTS) therein. I am guessing that these should actually be 
installed in /usr/local/sbin (i.e prefix/sbin).

The attached patch does this.

Regards

Mark

[-- Attachment #2: src-Makefile.am.patch --]
[-- Type: text/x-patch, Size: 380 bytes --]

diff --git a/src/Makefile.am b/src/Makefile.am
index c1a7e80..21f30dd 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -28,7 +28,7 @@ bin_PROGRAMS =
 bin_DEBUGPROGRAMS =
 sbin_PROGRAMS =
 # like sbin_SCRIPTS but can be used to install to e.g. /usr/sbin
-ceph_sbindir = $(prefix)$(sbindir)
+ceph_sbindir = $(sbindir)
 ceph_sbin_SCRIPTS = \
 	ceph-disk \
 	ceph-disk-prepare \

             reply	other threads:[~2013-07-07  5:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07  5:15 Mark Kirkwood [this message]
2013-07-08  6:51 ` Possible bug in src/Makefile.am Mark Kirkwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D8F96B.5040902@catalyst.net.nz \
    --to=mark.kirkwood@catalyst.net.nz \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.