From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51D92B19.8000706@free-electrons.com> Date: Sun, 07 Jul 2013 10:47:21 +0200 From: Alexandre Belloni MIME-Version: 1.0 To: Jonathan Cameron CC: Shawn Guo , Jonathan Cameron , jimwall@q.com, brian@crystalfontz.com, Maxime Ripard , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Rob Landley , Rob Herring , Grant Likely Subject: Re: [PATCHv3 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging References: <1372094699-3832-1-git-send-email-alexandre.belloni@free-electrons.com> <1372094699-3832-3-git-send-email-alexandre.belloni@free-electrons.com> <51D7F0E6.2000008@kernel.org> In-Reply-To: <51D7F0E6.2000008@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 06/07/2013 12:26, Jonathan Cameron wrote: > On 06/24/2013 06:24 PM, Alexandre Belloni wrote: >> From: Maxime Ripard >> >> The ADCs connected to this bus have been experiencing some timeout >> issues when using the iMX28 i2c controller. Switching back to bitbanging >> solves this. >> >> Signed-off-by: Maxime Ripard >> Signed-off-by: Alexandre Belloni > > As there are no disadvantages in taking the driver through IIO and these changes > through the appropriate arch trees, I'd not propose to take these through IIO > (even when the discussion is done) unless specifically asked to. > Sure, especially since, we may finally not move to i2c bitbanging. I'll probably resend a new version of those patches separately. Shawn, please wait for the i2c-mxs PIO/DMA mode discussion to end before applying. If possible, I would prefer not using bitbanging. Regards, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Sun, 07 Jul 2013 10:47:21 +0200 Subject: [PATCHv3 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging In-Reply-To: <51D7F0E6.2000008@kernel.org> References: <1372094699-3832-1-git-send-email-alexandre.belloni@free-electrons.com> <1372094699-3832-3-git-send-email-alexandre.belloni@free-electrons.com> <51D7F0E6.2000008@kernel.org> Message-ID: <51D92B19.8000706@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/07/2013 12:26, Jonathan Cameron wrote: > On 06/24/2013 06:24 PM, Alexandre Belloni wrote: >> From: Maxime Ripard >> >> The ADCs connected to this bus have been experiencing some timeout >> issues when using the iMX28 i2c controller. Switching back to bitbanging >> solves this. >> >> Signed-off-by: Maxime Ripard >> Signed-off-by: Alexandre Belloni > > As there are no disadvantages in taking the driver through IIO and these changes > through the appropriate arch trees, I'd not propose to take these through IIO > (even when the discussion is done) unless specifically asked to. > Sure, especially since, we may finally not move to i2c bitbanging. I'll probably resend a new version of those patches separately. Shawn, please wait for the i2c-mxs PIO/DMA mode discussion to end before applying. If possible, I would prefer not using bitbanging. Regards, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCHv3 2/3] ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging Date: Sun, 07 Jul 2013 10:47:21 +0200 Message-ID: <51D92B19.8000706@free-electrons.com> References: <1372094699-3832-1-git-send-email-alexandre.belloni@free-electrons.com> <1372094699-3832-3-git-send-email-alexandre.belloni@free-electrons.com> <51D7F0E6.2000008@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51D7F0E6.2000008-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jonathan Cameron Cc: Shawn Guo , Jonathan Cameron , jimwall@q.com, brian-ZKiFAVwZFM2FeswfMrDH8w@public.gmane.org, Maxime Ripard , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Landley , Rob Herring , Grant Likely List-Id: devicetree@vger.kernel.org On 06/07/2013 12:26, Jonathan Cameron wrote: > On 06/24/2013 06:24 PM, Alexandre Belloni wrote: >> From: Maxime Ripard >> >> The ADCs connected to this bus have been experiencing some timeout >> issues when using the iMX28 i2c controller. Switching back to bitbanging >> solves this. >> >> Signed-off-by: Maxime Ripard >> Signed-off-by: Alexandre Belloni > > As there are no disadvantages in taking the driver through IIO and these changes > through the appropriate arch trees, I'd not propose to take these through IIO > (even when the discussion is done) unless specifically asked to. > Sure, especially since, we may finally not move to i2c bitbanging. I'll probably resend a new version of those patches separately. Shawn, please wait for the i2c-mxs PIO/DMA mode discussion to end before applying. If possible, I would prefer not using bitbanging. Regards, -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com