From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwObS-0008Q9-KP for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:28:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwObR-0000SC-G2 for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:28:34 -0400 Received: from [222.73.24.84] (port=23473 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwObR-0000Ra-5k for qemu-devel@nongnu.org; Mon, 08 Jul 2013 23:28:33 -0400 Message-ID: <51DB835F.9080906@cn.fujitsu.com> Date: Tue, 09 Jul 2013 11:28:31 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <1372931597-28115-1-git-send-email-gaowanlong@cn.fujitsu.com> <1372931597-28115-2-git-send-email-gaowanlong@cn.fujitsu.com> <20130705184115.GP13956@otherpad.lan.raisama.net> <51DB0CD1.7030501@redhat.com> <87txk4q2f2.fsf@codemonkey.ws> In-Reply-To: <87txk4q2f2.fsf@codemonkey.ws> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option Reply-To: gaowanlong@cn.fujitsu.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Eduardo Habkost , qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, afaerber@suse.de, Wanlong Gao On 07/09/2013 03:25 AM, Anthony Liguori wrote: > Eric Blake writes: > >> On 07/05/2013 12:41 PM, Eduardo Habkost wrote: >>> On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: >>>> From: Bandan Das >>>> >>>> This allows us to use the "cpus" property multiple times >>>> to specify multiple cpu (ranges) to the -numa option : >>>> >>>> -numa node,cpus=1,cpus=2,cpus=4 >>>> or >>>> -numa node,cpus=1-3,cpus=5 >>>> >>>> Note that after this patch, the defalut suffix of "-numa node,mem=N" >>>> will no longer be "M". So we must add the suffix "M" like "-numa node,mem=NM" >>>> when assigning "N MB" of node memory size. >>> >>> Such an incompatible change is not acceptable, as it would break >>> existing configurations. libvirt doesn't specify any suffix and expects >>> it to always mean "MB". >> >> Newer libvirt can be taught to append 'M' when it detects it is talking >> to newer qemu. While you have a point that it is annoying to force >> users to upgrade to a newer libvirt merely because they upgraded qemu, >> the libvirt point of view is that the following are supported: >> >> old libvirt -> old qemu >> new libvirt -> old qemu >> new libvirt -> new qemu >> >> but that this combination is always best effort and not required to work: >> >> old libvirt -> new qemu > > That's fine for libvirt, but we don't break command line compatibility > in QEMU. So this patch needs to change. But if we follow Paolo's suggestion like: -numa node,nodeid=0,cpus=0 -numa node,nodeid=1,cpus=1 \ -numa mem,nodeid=0,size=1G,policy=membind,hostnode=0-1 -numa mem,nodeid=1,size=2G,policy=interleave,hostnode=1 We already break the command line compatibility. Why not change it be a really "size" options without default suffix? Thanks, Wanlong Gao > > Regards, > > Anthony Liguori > >> >> -- >> Eric Blake eblake redhat com +1-919-301-3266 >> Libvirt virtualization library http://libvirt.org > >