From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram Date: Tue, 09 Jul 2013 09:29:51 +0300 Message-ID: <51DBADDF.3010103@kernel.org> References: <1373212827-17409-1-git-send-email-sasha.levin@oracle.com> <20130708105841.GC22057@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sasha Levin , KVM General , Michael Tokarev , Michael Ellerman , Asias He , jonathan.austin@arm.com To: Will Deacon Return-path: Received: from mail-lb0-f173.google.com ([209.85.217.173]:61767 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062Ab3GIG3z (ORCPT ); Tue, 9 Jul 2013 02:29:55 -0400 Received: by mail-lb0-f173.google.com with SMTP id v1so4450379lbd.4 for ; Mon, 08 Jul 2013 23:29:53 -0700 (PDT) In-Reply-To: <20130708105841.GC22057@mudshark.cambridge.arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2013 01:58 PM, Will Deacon wrote: > Hi guys, > > On Mon, Jul 08, 2013 at 09:12:26AM +0100, Pekka Enberg wrote: >> On Sun, Jul 7, 2013 at 7:00 PM, Sasha Levin wrote: >>> Commit "kvm tools: virtio: remove hardcoded assumptions >>> about guest page size" has introduced a bug that prevented >>> guests with more than 4gb of ram from booting. >>> >>> The issue is that 'pfn' is a 32bit integer, so when multiplying >>> it by page size to get the actual page will cause an overflow if >>> the pfn referred to a memory area above 4gb. >>> >>> Signed-off-by: Sasha Levin >> >> Will, Michael, Asias, good to merge? > > I'm at a conference at the moment, so unable to test this patch, but it > looks simple and correct enough to me: > > Acked-by: Will Deacon Applied, thanks a lot! Pekka