From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: George Cherian <george.cherian@ti.com>,
linux-usb@vger.kernel.org, balbi@ti.com,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-omap@vger.kernel.org, kishon@ti.com
Subject: Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework
Date: Tue, 09 Jul 2013 09:13:04 +0200 [thread overview]
Message-ID: <51DBB800.3010704@linutronix.de> (raw)
In-Reply-To: <20130708203435.GB2596@localhost>
On 07/08/2013 10:34 PM, Ezequiel Garcia wrote:
> Hi,
Hi,
> On Mon, Jul 08, 2013 at 09:44:33PM +0200, Sebastian Andrzej Siewior wrote:
>
>> We need two nodes each one with a glue layer and a musb child node. The
>> instances crap in kernel has to vanish. Also that means your phy nodes
>> are wrong. This is not musb with two ports but two musb instances each
>> with one port.
>>
>
> I agree completely. The current DT representation looks definitely odd,
> and we should be looking at improving it.
>
> I wonder if this is now possible, given the DT is supposed to be stable ABI.
I posted this [0] and Felipe + Benoit were pro change. I am still not
sure if this is okay or just one glue layer per instance so I delay
this until I am sure. Stable or not, what currently have in is beyond
broken and it can't be fixed in kernel.
I would add some code to check for the old nodes and give a proper
warning and how to react. This should reduce the pain full search.
[0]
http://git.breakpoint.cc/cgit.cgi/bigeasy/linux.git/commit/?h=am335x_usb&id=0a60cd77ee50edd8cd07cbd699ed67b2c4b2ab93
Sebastian
next prev parent reply other threads:[~2013-07-09 7:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 10:43 [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 10:43 ` [PATCH 1/5] usb: musb: dsps: enable dual instance support for am33xx platform George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 10:43 ` [PATCH 2/5] usb: phy: phy-omap-control: Add API to power on/off USB PHY for AM335X George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 11:37 ` Kishon Vijay Abraham I
2013-07-08 11:37 ` Kishon Vijay Abraham I
2013-07-08 10:43 ` [PATCH 3/5] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 11:52 ` Kishon Vijay Abraham I
2013-07-08 11:52 ` Kishon Vijay Abraham I
2013-07-08 10:43 ` [PATCH 4/5] arm: dts: Add USB phy nodes for AM33XX George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 11:54 ` Kishon Vijay Abraham I
2013-07-08 11:54 ` Kishon Vijay Abraham I
2013-07-08 10:43 ` [PATCH 5/5] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs George Cherian
2013-07-08 10:43 ` George Cherian
2013-07-08 12:08 ` Kishon Vijay Abraham I
2013-07-08 12:08 ` Kishon Vijay Abraham I
2013-07-08 19:44 ` [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework Sebastian Andrzej Siewior
[not found] ` <51DB16A1.6010006-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-08 20:34 ` Ezequiel Garcia
2013-07-08 20:34 ` Ezequiel Garcia
2013-07-09 7:13 ` Sebastian Andrzej Siewior [this message]
2013-07-09 5:40 ` George Cherian
2013-07-09 5:40 ` George Cherian
2013-07-09 11:35 ` Kishon Vijay Abraham I
2013-07-09 11:35 ` Kishon Vijay Abraham I
[not found] ` <51DBF59F.1030109-l0cyMroinI0@public.gmane.org>
2013-07-10 4:56 ` George Cherian
2013-07-10 4:56 ` George Cherian
2013-07-10 5:23 ` Felipe Balbi
2013-07-10 5:23 ` Felipe Balbi
2013-07-10 5:43 ` George Cherian
2013-07-10 5:43 ` George Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBB800.3010704@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.