From: "Frédéric DALLEAU" <frederic.dalleau@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v8 5/8] Bluetooth: Use voice setting in defered SCO connection request
Date: Tue, 09 Jul 2013 11:36:58 +0200 [thread overview]
Message-ID: <51DBD9BA.10909@linux.intel.com> (raw)
In-Reply-To: <9F18507A-5260-4B81-AF57-0EF2D8BC3A0C@holtmann.org>
Marcel,
Le 08/07/2013 21:12, Marcel Holtmann a écrit :
> Hi Fred,
+ __constant_cpu_to_le16(SCO_AIRMODE_TRANSP);
> why do we hardcode here …
>
>> + cp.retrans_effort = 0x02;
>> + break;
>> + case SCO_AIRMODE_CVSD:
>> + cp.max_latency = __constant_cpu_to_le16(0xffff);
>> + cp.content_format = cpu_to_le16(setting);
>
> … and use setting here.
>
SCO_AIRMODE_CVSD needs some additional bits describing Input coding and
Data format. There is no additional bits for SCO_AIRMODE_TRANSP.
But having it common will fix this ugly line break :)
Fred
next prev parent reply other threads:[~2013-07-09 9:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 15:01 [PATCH v8 0/8] sco: SCO socket option for voice_setting Frédéric Dalleau
2013-07-05 15:01 ` [PATCH v8 1/8] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-07-05 15:01 ` [PATCH v8 2/8] Bluetooth: Remove unused mask parameter in sco_conn_defer_accept Frédéric Dalleau
2013-07-08 19:10 ` Marcel Holtmann
2013-07-09 7:00 ` Frédéric DALLEAU
2013-07-09 7:37 ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 3/8] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-07-08 19:17 ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 4/8] Bluetooth: Constants declaration for SCO airmode Frédéric Dalleau
2013-07-08 19:04 ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 5/8] Bluetooth: Use voice setting in defered SCO connection request Frédéric Dalleau
2013-07-08 19:12 ` Marcel Holtmann
2013-07-09 9:36 ` Frédéric DALLEAU [this message]
2013-07-05 15:01 ` [PATCH v8 6/8] Bluetooth: Parameters for outgoing SCO connections Frédéric Dalleau
2013-07-08 19:20 ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 7/8] Bluetooth: SCO connection fallback Frédéric Dalleau
2013-07-08 19:23 ` Marcel Holtmann
2013-07-09 9:57 ` Frédéric DALLEAU
2013-07-09 14:25 ` Marcel Holtmann
2013-07-05 15:01 ` [PATCH v8 8/8] Bluetooth: Prevent transparent SCO on older devices Frédéric Dalleau
2013-07-08 2:33 ` Vinicius Costa Gomes
2013-07-08 9:31 ` Frédéric DALLEAU
2013-07-08 19:25 ` Marcel Holtmann
2013-07-12 13:48 ` Frédéric DALLEAU
2013-07-12 16:35 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBD9BA.10909@linux.intel.com \
--to=frederic.dalleau@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.