From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khlebnikov Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup Date: Tue, 09 Jul 2013 21:12:55 +0400 Message-ID: <51DC4497.6060107@openvz.org> References: <20130708100046.14417.12932.stgit@zurg> <20130709153907.GA17972@thunk.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=oFbW8S/X0mTg0ujUM8Y8TY6mN4YMzwAQDG273tv+Tuk=; b=bpc9eEJuwGglEXFdtdltSvUjITjB8w66LL0tOJOhRTosBEwnTO7DLZP+9NFlY6qm6F G/fRXrD6LzW6UoJHzAtClo/Onwo25Nnki/3auaLAX08tHb5w5ayTLXQyq5pcY2Angxt6 H4ByvN7cB1mhhouxKzCApaCvBQ0W/o+Q5E3RRWXr7coafJGVDL+4AueX4BVrVe8k2pa/ XYP38qJntKmY9hNYgluOsEqrRk4UfvL7LuJPxRi2jPExHDuvjY+Eg2ScQtdgEEXG73NI EOx9yEqjd/Y86dFDrVp/IWsxd9XWGmrQd4/14XB5fLyeW5/KeLtIuYoOC0NWpLsRZp5Y YLQA== In-Reply-To: <20130709153907.GA17972-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Theodore Ts'o , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Sha Zhengju , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org Theodore Ts'o wrote: > Another major problem with this concept is that it lumps all I/O's > into a single cgroup. So I/O's from pseudo filesystems (such as > reading from /sys/kernel/debug/tracing/trace_pipe), networked file > systems such as NFS, and I/O to various different block devices all > get counted in a single per-cgroup limit. > > This doesn't seem terribly useful to me. Network resources and block > resources are quite different, and counting pseudo file systems and > ram disks makes no sense at all. Yep, I know it. I've already mentioned about this as first planned improvement: |* Split bdi into several tiers and account them separately. For example: | hdd/ssd/usb/nfs. In complicated containerized environments that might be | different kinds of storages with different limits and billing. This is more | usefull that independent per-disk accounting and much easier to implement | because all per-tier structures are allocated before disk appearance. Accounting each BDI separately doesn't very useful too, so I've chosen something in the middle. > > Regards, > > - Ted > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo-Bw31MaZKKs0EbZ0PF+XxCw@public.gmane.org For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx134.postini.com [74.125.245.134]) by kanga.kvack.org (Postfix) with SMTP id 8CAE16B0032 for ; Tue, 9 Jul 2013 13:13:00 -0400 (EDT) Received: by mail-la0-f48.google.com with SMTP id lx15so4878991lab.21 for ; Tue, 09 Jul 2013 10:12:58 -0700 (PDT) Message-ID: <51DC4497.6060107@openvz.org> Date: Tue, 09 Jul 2013 21:12:55 +0400 From: Konstantin Khlebnikov MIME-Version: 1.0 Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup References: <20130708100046.14417.12932.stgit@zurg> <20130709153907.GA17972@thunk.org> In-Reply-To: <20130709153907.GA17972@thunk.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Theodore Ts'o , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , cgroups@vger.kernel.org, Andrew Morton , Sha Zhengju , devel@openvz.org Theodore Ts'o wrote: > Another major problem with this concept is that it lumps all I/O's > into a single cgroup. So I/O's from pseudo filesystems (such as > reading from /sys/kernel/debug/tracing/trace_pipe), networked file > systems such as NFS, and I/O to various different block devices all > get counted in a single per-cgroup limit. > > This doesn't seem terribly useful to me. Network resources and block > resources are quite different, and counting pseudo file systems and > ram disks makes no sense at all. Yep, I know it. I've already mentioned about this as first planned improvement: |* Split bdi into several tiers and account them separately. For example: | hdd/ssd/usb/nfs. In complicated containerized environments that might be | different kinds of storages with different limits and billing. This is more | usefull that independent per-disk accounting and much easier to implement | because all per-tier structures are allocated before disk appearance. Accounting each BDI separately doesn't very useful too, so I've chosen something in the middle. > > Regards, > > - Ted > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752141Ab3GIRND (ORCPT ); Tue, 9 Jul 2013 13:13:03 -0400 Received: from mail-la0-f51.google.com ([209.85.215.51]:58645 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644Ab3GIRNA (ORCPT ); Tue, 9 Jul 2013 13:13:00 -0400 Message-ID: <51DC4497.6060107@openvz.org> Date: Tue, 09 Jul 2013 21:12:55 +0400 From: Konstantin Khlebnikov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130119 Firefox/10.0.11esrpre Iceape/2.7.12 MIME-Version: 1.0 To: "Theodore Ts'o" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , cgroups@vger.kernel.org, Andrew Morton , Sha Zhengju , devel@openvz.org Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup References: <20130708100046.14417.12932.stgit@zurg> <20130709153907.GA17972@thunk.org> In-Reply-To: <20130709153907.GA17972@thunk.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Theodore Ts'o wrote: > Another major problem with this concept is that it lumps all I/O's > into a single cgroup. So I/O's from pseudo filesystems (such as > reading from /sys/kernel/debug/tracing/trace_pipe), networked file > systems such as NFS, and I/O to various different block devices all > get counted in a single per-cgroup limit. > > This doesn't seem terribly useful to me. Network resources and block > resources are quite different, and counting pseudo file systems and > ram disks makes no sense at all. Yep, I know it. I've already mentioned about this as first planned improvement: |* Split bdi into several tiers and account them separately. For example: | hdd/ssd/usb/nfs. In complicated containerized environments that might be | different kinds of storages with different limits and billing. This is more | usefull that independent per-disk accounting and much easier to implement | because all per-tier structures are allocated before disk appearance. Accounting each BDI separately doesn't very useful too, so I've chosen something in the middle. > > Regards, > > - Ted > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org