From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uwj1m-0006rN-4C for kexec@lists.infradead.org; Wed, 10 Jul 2013 01:17:07 +0000 Message-ID: <51DCB585.9030105@cn.fujitsu.com> Date: Wed, 10 Jul 2013 09:14:45 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH REPOST] kexec: return error of machine_kexec() fails References: <1373386597-3884-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1373386597-3884-1-git-send-email-swarren@wwwdotorg.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Stephen Warren Cc: Stephen Warren , kexec@lists.infradead.org, Eric Biederman , linux-kernel@vger.kernel.org 5LqOIDIwMTMvNy8xMCAwOjE2LCBTdGVwaGVuIFdhcnJlbiDlhpnpgZM6Cj4gRnJvbTogU3RlcGhl biBXYXJyZW4gPHN3YXJyZW5AbnZpZGlhLmNvbT4KPiAKPiBQcmlvciB0byBjb21taXQgM2FiODM1 MiAia2V4ZWMganVtcCIsIGlmIG1hY2hpbmVfa2V4ZWMoKSByZXR1cm5lZCwKPiBzeXNfcmVib290 KCkgd291bGQgcmV0dXJuIC1FSU5WQUwuIFRoaXMgcGF0Y2ggcmVzdG9yZXMgdGhpcyBiZWhhdmlv dXIKPiBmb3IgdGhlIG5vbi1LRVhFQ19KVU1QIGNhc2UsIHdoZXJlIG1hY2hpbmVfa2V4ZWMoKSBp cyBub3QgZXhwZWN0ZWQgdG8KPiByZXR1cm4uCj4gCj4gVGhpcyBzaXR1YXRpb24gY2FuIG9jY3Vy IG9uIEFSTSwgd2hlcmUga2V4ZWMgcmVxdWlyZXMgZGlzYWJsaW5nIGFsbCBidXQKPiBvbmUgQ1BV IHVzaW5nIENQVSBob3RwbHVnLiBIb3dldmVyLCBpZiBob3RwbHVnIGlzbid0IHN1cHBvcnRlZCBi eSB0aGUKPiBwYXJ0aWN1bGFyIEhXIHRoZSBrZXJuZWwgaXMgcnVubmluZyBvbiwgdGhlbiBrZXhl YyBjYW5ub3Qgc3VjY2VlZC4KCkkgZG9uJ3QgaGF2ZSBhbiBBUk0gbWFjaGluZSwgYnV0IEkgYmVs aWV2ZSB5b3UgYXJlIHJpZ2h0IGJ5IHJlYWRpbmcgdGhlCmNvZGUuIFNvCgpBY2tlZC1ieTogWmhh bmcgWWFuZmVpIDx6aGFuZ3lhbmZlaUBjbi5mdWppdHN1LmNvbT4KCj4gCj4gU2lnbmVkLW9mZi1i eTogU3RlcGhlbiBXYXJyZW4gPHN3YXJyZW5AbnZpZGlhLmNvbT4KPiBBY2tlZC1ieTogV2lsbCBE ZWFjb24gPHdpbGwuZGVhY29uQGFybS5jb20+Cj4gLS0tCj4gIGtlcm5lbC9rZXhlYy5jIHwgMiAr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2tl cm5lbC9rZXhlYy5jIGIva2VybmVsL2tleGVjLmMKPiBpbmRleCA1OWY3YjU1Li5iZGUxMTkwIDEw MDY0NAo+IC0tLSBhL2tlcm5lbC9rZXhlYy5jCj4gKysrIGIva2VybmVsL2tleGVjLmMKPiBAQCAt MTcwMiw2ICsxNzAyLDggQEAgaW50IGtlcm5lbF9rZXhlYyh2b2lkKQo+ICAJCXBtX3Jlc3RvcmVf Y29uc29sZSgpOwo+ICAJCXVubG9ja19zeXN0ZW1fc2xlZXAoKTsKPiAgCX0KPiArI2Vsc2UKPiAr CWVycm9yID0gLUVJTlZBTDsKPiAgI2VuZGlmCj4gIAo+ICAgVW5sb2NrOgo+IAoKCi0tIApUaGFu a3MuClpoYW5nIFlhbmZlaQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979Ab3GJBOw (ORCPT ); Tue, 9 Jul 2013 21:14:52 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64866 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753735Ab3GJBOv convert rfc822-to-8bit (ORCPT ); Tue, 9 Jul 2013 21:14:51 -0400 X-IronPort-AV: E=Sophos;i="4.87,1032,1363104000"; d="scan'208";a="7840983" Message-ID: <51DCB585.9030105@cn.fujitsu.com> Date: Wed, 10 Jul 2013 09:14:45 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Stephen Warren CC: Eric Biederman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren Subject: Re: [PATCH REPOST] kexec: return error of machine_kexec() fails References: <1373386597-3884-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1373386597-3884-1-git-send-email-swarren@wwwdotorg.org> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/07/10 09:13:05, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/07/10 09:13:09 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013/7/10 0:16, Stephen Warren 写道: > From: Stephen Warren > > Prior to commit 3ab8352 "kexec jump", if machine_kexec() returned, > sys_reboot() would return -EINVAL. This patch restores this behaviour > for the non-KEXEC_JUMP case, where machine_kexec() is not expected to > return. > > This situation can occur on ARM, where kexec requires disabling all but > one CPU using CPU hotplug. However, if hotplug isn't supported by the > particular HW the kernel is running on, then kexec cannot succeed. I don't have an ARM machine, but I believe you are right by reading the code. So Acked-by: Zhang Yanfei > > Signed-off-by: Stephen Warren > Acked-by: Will Deacon > --- > kernel/kexec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 59f7b55..bde1190 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1702,6 +1702,8 @@ int kernel_kexec(void) > pm_restore_console(); > unlock_system_sleep(); > } > +#else > + error = -EINVAL; > #endif > > Unlock: > -- Thanks. Zhang Yanfei