From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwlr9-0000V9-21 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:18:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwlr7-0008C8-W0 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:18:18 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:47919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwlr7-0008Br-Oy for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:18:17 -0400 Message-ID: <51DCE085.2030409@msgid.tls.msk.ru> Date: Wed, 10 Jul 2013 08:18:13 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <874nc337gq.fsf@codemonkey.ws> <51DC5DEA.4060901@msgid.tls.msk.ru> <87li5fsbrd.fsf@codemonkey.ws> In-Reply-To: <87li5fsbrd.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org 10.07.2013 00:45, Anthony Liguori wrote: > Michael Tokarev writes: > >> 09.07.2013 22:37, Anthony Liguori wrote: >>> Michael Tokarev writes: >>> >>>> It looks like initially there was -nographic option to turn >>>> off display, now there's another option of the same sort, >>>> -display none. But code in other places of qemu checks for >>>> DT_NOGRAPHIC and does not work well with -display none. >>>> Make DT_NOGRAPHIC an internal version which selects DT_NONE, >>>> and check for that in all other places where previously we >>>> checked for DT_NOGRAPHIC. >> [] >>> Breaks make check: >>> >>> main-loop: WARNING: I/O thread spun for 1000 iterations >>> ** >>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0) >>> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b >> >> Sure, because the test is bogus. > > No, it's a guest ABI. You cannot change the guest ABI. > > -display none != -nographic. > > nographic gives you -display none plus a stdio serial port (with muxing > magic). > > -display none should not imply stdio serial port. The vc goes to a > dummy display. That's a major semantic difference. So we're back to the original bugreport by Todd Fries -- apparently all my attempts to describe the proposed ways to change it failed. Note that -nographics does NOT imply a serial port either, because it can be redirected elsewhere. /mjt