From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwmI0-0000Qj-6x for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwmHy-0001mn-W9 for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:46:04 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:60870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwmHy-0001lW-OP for qemu-devel@nongnu.org; Wed, 10 Jul 2013 00:46:02 -0400 Message-ID: <51DCE707.8090606@msgid.tls.msk.ru> Date: Wed, 10 Jul 2013 08:45:59 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <874nc337gq.fsf@codemonkey.ws> <51DC5DEA.4060901@msgid.tls.msk.ru> <87li5fsbrd.fsf@codemonkey.ws> <87y59f1l71.fsf@codemonkey.ws> In-Reply-To: <87y59f1l71.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , qemu-devel@nongnu.org 10.07.2013 01:24, Anthony Liguori wrote: > Peter Maydell writes: > >> On 9 July 2013 21:45, Anthony Liguori wrote: >>> Michael Tokarev writes: >>>> 09.07.2013 22:37, Anthony Liguori wrote: >>>>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0) >>>>> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b >>>> >>>> Sure, because the test is bogus. >>> >>> No, it's a guest ABI. You cannot change the guest ABI. >> >> Why the heck are we telling the guest that the user >> specified -nographic anyhow? It's a dumb guest ABI... > > I believe OpenBIOS uses this to determine if it should display messages > on serial or on the graphic display. This is actually exactly the thing this very patch changes: it stops relying on -nographics and passes -display none to the bios/firmware instead. And the documentation has been updated accordingly, also in this very patch: hw/nvram/fw_cfg.c - fw_cfg_add_i16(s, FW_CFG_NOGRAPHIC, (uint16_t)(display_type == DT_NOGRAPHIC)); + fw_cfg_add_i16(s, FW_CFG_NOGRAPHIC, (uint16_t)(display_type == DT_NONE)); hw/sparc/sun4m.c slavio_serial_ms_kbd_init(hwdef->ms_kb_base, slavio_irq[14], - display_type == DT_NOGRAPHIC, ESCC_CLOCK, 1); + display_type == DT_NONE, ESCC_CLOCK, 1); qemu-options.hx @item none Do not display video output. The guest will still see an emulated graphics card, but its output will not be displayed to the QEMU -user. This option differs from the -nographic option in that it +user. The fact that we have no display is passed to firmware and +affects a few other places depending on the target architecture, +like switching console output to serial console or disabling keyboard +input. + +This option differs from the -nographic option in that it only affects what is done with video output; -nographic also changes the destination of the serial and parallel port data. Besides, -- I just noticed -- we're discussing a V1 of this patch, while I already sent a v3, -- it has a much more appropriate logic for the Ctrl+C handling. The only issue I see with it is the make check breakage which is easy to fix by s/==0/==1/. Thanks, /mjt