From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] cmd_bootm.c: Make bootz consume 'bootz' from argv, decrement argc
Date: Tue, 09 Jul 2013 22:59:02 -0600 [thread overview]
Message-ID: <51DCEA16.8050106@wwwdotorg.org> (raw)
In-Reply-To: <1373398497-4658-1-git-send-email-trini@ti.com>
On 07/09/2013 01:34 PM, Tom Rini wrote:
> Like 'bootm', 'bootz' needs to consume 'bootz' so that the rest of the
> state functions will work.
I found that the Raspberry Pi was randomly crashing with recent
u-boot/master (bisect points at/near commit 35fc84f "Refactor the bootm
command to reduce code duplication"; there is some slight variation in
symptoms around there), or sometimes just spewing errors from bootz. I
found the following commits on the mailing list:
> e1ec5e0 cmd_bootm.c: Make bootz handle BOOTM_STATE_FINDOTHER itself
> c83a89d cmd_bootm.c: Make bootz consume 'bootz' from argv, decrement argc
> d18cab6 bootm: Add the missing PREP stage to bootz and correct image handling
> 4766b32 bootm: Clean up bootz_setup() function
> f65d734 bootm: Require boot function only if it is about to be used
> bf6f341 bootm: Disable interrupts only when loading
> a01d5e4 bootm: Handle errors consistently
... and the combination of all 7 of them (but not just Simon's 5
patches) seems to solve this, so,
Tested-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2013-07-10 4:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 19:34 [U-Boot] [PATCH 1/2] cmd_bootm.c: Make bootz consume 'bootz' from argv, decrement argc Tom Rini
2013-07-09 19:34 ` [U-Boot] [PATCH 2/2] cmd_bootm.c: Make bootz handle BOOTM_STATE_FINDOTHER itself Tom Rini
2013-07-10 4:59 ` Stephen Warren [this message]
2013-07-10 9:53 ` [U-Boot] [PATCH 1/2] cmd_bootm.c: Make bootz consume 'bootz' from argv, decrement argc Simon Glass
2013-07-10 15:38 ` Stephen Warren
2013-07-10 13:19 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DCEA16.8050106@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.