From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwmdZ-00041F-Mh for qemu-devel@nongnu.org; Wed, 10 Jul 2013 01:08:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwmdY-0000NI-Gb for qemu-devel@nongnu.org; Wed, 10 Jul 2013 01:08:21 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwmdY-0000ND-8w for qemu-devel@nongnu.org; Wed, 10 Jul 2013 01:08:20 -0400 Message-ID: <51DCEC3F.4020503@msgid.tls.msk.ru> Date: Wed, 10 Jul 2013 09:08:15 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <874nc337gq.fsf@codemonkey.ws> <51DC5DEA.4060901@msgid.tls.msk.ru> <87li5fsbrd.fsf@codemonkey.ws> <87y59f1l71.fsf@codemonkey.ws> <51DCE707.8090606@msgid.tls.msk.ru> In-Reply-To: <51DCE707.8090606@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , qemu-devel@nongnu.org 10.07.2013 08:45, Michael Tokarev wrote: [] > Besides, -- I just noticed -- we're discussing a V1 of this patch, > while I already sent a v3, -- it has a much more appropriate logic > for the Ctrl+C handling. The only issue I see with it is the make > check breakage which is easy to fix by s/==0/==1/. I updated the git branch on my site -- http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-dt-nographic (two patches on the top). This now includes the `make check' fix by flipping the check (FW_CFG_NOGRAPHIC==1 vs ==0), more documentation rewording (suggested by Peter) and Reviewed-by tags. And yes, I dislike this mess too -- neither -nographic nor -display none should be tied with guest serial port. Better approach for the Ctrl+C handling has been proposed by pbonzini. Better suggestions for FW_CFG_NOGRAPHIC welcome. Maybe something like -serial-console (linux has console=ttyS0,tty1) which will be turned on by -nographic and which will be passed to firmware as FW_CFG_NOGRAPHIC, and which can be used in -serial none case to check for sanity. But actually, -display none isn't that bad of a choice here (and maybe we may also enforce non-none serial in case of -display none). Thanks, /mjt