All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbabic@denx.de (Stefano Babic)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: add tempmon node for imx6q thermal support
Date: Wed, 10 Jul 2013 10:10:00 +0200	[thread overview]
Message-ID: <51DD16D8.8070803@denx.de> (raw)
In-Reply-To: <20130710070915.GA12605@S2101-09.ap.freescale.net>

Hi Shawn,

On 10/07/2013 09:09, Shawn Guo wrote:

> Address 0x20C8180 is where TEMPMON control registers are - they are
> embedded in ANATOP block, while calibration data is stored in OCOTP fuse
> block.
> 

Thanks, it is clear now.

>> imx_thermal tempmon.7: invalid sensor calibration data
>> imx_thermal tempmon.7: failed to get sensor data
>> imx_thermal: probe of tempmon.7 failed with error -22
> 
> What's your chip revision?  Early revisions may not have the calibration
> data.  TO1.2 should have, I think.

That is the point - on the board I tested there is a T01.0 running.

> 
>> The driver is loaded successfully if I changed the tempdata to point to
>> 020C8180. Not sure if I get the right values from temp1_crit and
>> temp1_input, but no error at the initialisation. Am I missing something ?
> 
> It reads some data but that's not calibration data, so it should not work.
> 
> Also, you need a cpu_cooling fix [1], if you want to play the thermal
> patches on imx6q.

Understood, thanks.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-07-10  8:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  7:13 [PATCH] thermal: add imx thermal driver support Shawn Guo
2013-06-04  7:13 ` Shawn Guo
2013-06-04  7:17 ` [PATCH] ARM: dts: imx: add tempmon node for imx6q thermal support Shawn Guo
2013-07-09 14:59   ` Stefano Babic
2013-07-10  7:09     ` Shawn Guo
2013-07-10  8:10       ` Stefano Babic [this message]
2013-06-13  0:16 ` [PATCH] thermal: add imx thermal driver support Shawn Guo
2013-06-13  0:16   ` Shawn Guo
2013-06-13  3:12 ` Zhang Rui
2013-06-13  3:12   ` Zhang Rui
2013-06-13  4:12   ` Shawn Guo
2013-06-13  4:12     ` Shawn Guo
2013-06-13  5:14     ` Zhang Rui
2013-06-13  5:14       ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DD16D8.8070803@denx.de \
    --to=sbabic@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.