From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UwpiZ-0005qj-OW
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 04:25:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UwpiY-0003qi-I6
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 04:25:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:47261 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UwpiY-0003o7-5u
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 04:25:42 -0400
Message-ID: <51DD1A7F.1040809@suse.de>
Date: Wed, 10 Jul 2013 10:25:35 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cb482f5459c86cc928f95c19b061badaa9adc1e9.1373432540.git.peter.crosthwaite@xilinx.com>
	<CAFEAcA8MYogkOc+Vz_5U9rr82r+X=TG68RuRfhUMU3B-y8Lz1g@mail.gmail.com>
In-Reply-To: <CAFEAcA8MYogkOc+Vz_5U9rr82r+X=TG68RuRfhUMU3B-y8Lz1g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9
	Global Timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peter.crosthwaite@xilinx.com
Cc: devel@thom.fr.eu.org, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Am 10.07.2013 09:41, schrieb Peter Maydell:
> On 10 July 2013 06:08,  <peter.crosthwaite@xilinx.com> wrote:
>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore=
.
>> The timer is shared but each CPU has a private independent comparator
>> and interrupt.
>>
>> Original version contributed by Francois LEGAL.
>>
>> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>> ---
>> Francois, do you want to re-add your SOB? I have changed the device
>> a lot since your V2.

If you have a DCO for a patch you're reusing, you should never "drop" it
from your patch. You can still leave the textual explanation there.

> The usual way to indicate this (assuming Francois signed off the
> original patchset) is something like:
>=20
>   Signed-off-by: Original Author
>   [You: <short description of subsequent changes>]
>   Signed-off-by: Your Name

Add to that, the difference between From and SOB indicates that you did
more than just cosmetic touches. For example, when I wrote from scratch
a new SoC QOM object I used my From and the original author's Sob (to
put the blame on me while recording the DCO), whereas when I purely
updated code to MemoryRegions, Coding Style, QOM casts, etc. I use the
original author's From and [AF: ...].

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg