From: Alexey Galakhov <agalakhov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Force set console baudrate
Date: Wed, 10 Jul 2013 15:36:18 +0600 [thread overview]
Message-ID: <51DD2B12.3060106@gmail.com> (raw)
In-Reply-To: <20130710090131.GE516@pengutronix.de>
On 07/10/2013 03:01 PM, Sascha Hauer wrote:
> Anyway, maybe Jean-Christophe is right and we should do this in
> console_std_set by adding:
>
> if(flag && cdev->setbrg)
> cdev->setbrg(cdev, cdev->baudrate);
>
> This makes sure the hardware is only ever touched when the console is
> actually used.
>
> Sascha
>
Hi,
Agree. The only reason not do to so was that I saw the existing code,
especially the else clause in console_baudrate_set().
I just made v2 of the patch. I'm testing it right now. If it's Ok, I'll
submit it.
I did almost exactly this. The difference is that I do not call setbrg()
again if the device is already active. I also removed setbrg() call for
inactive devices from console_baudrate_set() as this would be duplicate
call now.
Regards,
Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-07-10 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 15:22 [PATCH] Force set console baudrate Alexey Galakhov
2013-07-09 17:43 ` Sascha Hauer
2013-07-09 18:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-07-09 20:09 ` Alexey Galakhov
2013-07-10 8:07 ` Jean-Christophe PLAGNIOL-VILLARD
2013-07-10 8:36 ` Alexey Galakhov
2013-07-10 9:01 ` Sascha Hauer
2013-07-10 9:36 ` Alexey Galakhov [this message]
2013-07-10 10:15 ` [PATCH 1/2] Revert "Force set console baudrate" Alexey Galakhov
2013-07-10 10:15 ` [PATCH 2/2] Force set console baudrate at enable time Alexey Galakhov
2013-07-10 21:28 ` Sascha Hauer
2013-07-11 7:13 ` Alexey Galakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD2B12.3060106@gmail.com \
--to=agalakhov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.