From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: num_tolerated_disk_barrier_failures is incorrect for RAID6
Date: Wed, 10 Jul 2013 14:23:16 +0200 [thread overview]
Message-ID: <51DD5234.40907@giantdisaster.de> (raw)
In-Reply-To: <1373457270-18909-1-git-send-email-idryomov@gmail.com>
On Wed, 10 Jul 2013 14:54:30 +0300, Ilya Dryomov wrote:
> Currently num_tolerated_disk_barrier_failures gets the value of
> fs_devices->num_devices in the RAID6 case. But, RAID6 can tolerate only
> two simultaneous failures, so set it to 2.
>
> CC: Stefan Behrens <sbehrens@giantdisaster.de>
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
> ---
> fs/btrfs/disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index b8b60b6..aecf788 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -3258,7 +3258,7 @@ int btrfs_calc_num_tolerated_disk_barrier_failures(
> BTRFS_BLOCK_GROUP_RAID10)) {
> num_tolerated_disk_barrier_failures = 1;
> } else if (flags &
> - BTRFS_BLOCK_GROUP_RAID5) {
> + BTRFS_BLOCK_GROUP_RAID6) {
> num_tolerated_disk_barrier_failures = 2;
> }
> }
>
ELATE :), Henrik Nordvik already fixed it with commit 15b0a89d7.
prev parent reply other threads:[~2013-07-10 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 11:54 [PATCH] Btrfs: num_tolerated_disk_barrier_failures is incorrect for RAID6 Ilya Dryomov
2013-07-10 12:23 ` Stefan Behrens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD5234.40907@giantdisaster.de \
--to=sbehrens@giantdisaster.de \
--cc=idryomov@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.