From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwv0j-0003pH-BX for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:04:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uwv0d-0001Mx-Ci for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:04:49 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:44588 helo=mx01.kamp.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Uwv0d-0001Mr-0T for qemu-devel@nongnu.org; Wed, 10 Jul 2013 10:04:43 -0400 Message-ID: <51DD69F8.3050305@kamp.de> Date: Wed, 10 Jul 2013 16:04:40 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1372338695-411-1-git-send-email-pl@kamp.de> <1372338695-411-11-git-send-email-pl@kamp.de> <20130710113313.GK3898@dhcp-200-207.str.redhat.com> In-Reply-To: <20130710113313.GK3898@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 10.07.2013 13:33, schrieb Kevin Wolf: > Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben: >> if the target does not support UNMAP or the request >> is too big silently ignore the discard request. >> >> Signed-off-by: Peter Lieven > Why not loop for the "too big" case? You can probably use the same logic > for unmapping the whole device in .bdrv_create and here. right, but looping in an aio function seemed not so trivial to me. it seems more and more obvious to me that the best would be to change all the remaining aio routines to co routines. in this case i could add the too big logic in iscsi_co_discard and simply call it from iscsi_co_write_zeroes. Peter > > Kevin